[WIP] Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker()

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 901 matching lines @@
   }
 
   WTF::Optional<DocumentMarker::MarkerType> type = markerTypeFrom(markerType);
   if (!type) {
     exceptionState.throwDOMException(
         SyntaxError,
         "The marker type provided ('" + markerType + "') is invalid.");
     return;
   }
 
+  // Grammar and Spelling markers are the only marker types that can be set with
+  // just a range
+  if (type != DocumentMarker::Grammar && type != DocumentMarker::Spelling) {

[yosin_UTC9, 2017/03/30 01:48:57]

Move this check at end of function to utilize early-return style.

+    exceptionState.throwDOMException(
+        SyntaxError,
+        "Marker of type '" + markerType +
+            "' was provided; type must be either Grammar or Spelling.");
+    return;
+  }
+
   document->updateStyleAndLayoutIgnorePendingStylesheets();
-  document->markers().addMarker(range->startPosition(), range->endPosition(),
-                                type.value());
+
+  if (type == DocumentMarker::Grammar) {
+    document->markers().addGrammarMarker(range->startPosition(),

[yosin_UTC9, 2017/03/30 01:48:57]

Let's use early return style.

+                                         range->endPosition());
+  } else {
+    document->markers().addSpellingMarker(range->startPosition(),
+                                          range->endPosition());
+  }
 }
 
 unsigned Internals::markerCountForNode(Node* node,
                                        const String& markerType,
                                        ExceptionState& exceptionState) {
   DCHECK(node);
   WTF::Optional<DocumentMarker::MarkerTypes> markerTypes =
       markerTypesFrom(markerType);
   if (!markerTypes) {
     exceptionState.throwDOMException(
@@ skipping 2275 matching lines @@
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 void Internals::setIsLowEndDevice(bool isLowEndDevice) {
   MemoryCoordinator::setIsLowEndDeviceForTesting(isLowEndDevice);
 }
 
 }  // namespace blink