cc/paint: Remove cc::PaintSurface.

cc/paint: Remove cc::PaintSurface.

The callers can now create a bitmap to wrap a SkiaPaintCanvas for
raster.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e76c333410b1d

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#460468}
Committed: https://chromium.googlesource.com/chromium/src/+/60900cbcf95fb50ed89330e5d26d5f37f9b845ef

[Khushal, 2017-03-20 21:34:04]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers now create a SkBitmap, use it to create a raster SkCanvas,
and wrap it with the cc::SkiaPaintCanvas.

BUG=703320
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers now create a SkBitmap, use it to create a raster SkCanvas,
and wrap it with the cc::SkiaPaintCanvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Khushal, 2017-03-20 21:34:08]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers now create a SkBitmap, use it to create a raster SkCanvas,
and wrap it with the cc::SkiaPaintCanvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers now create a SkBitmap, use it to create a raster SkCanvas,
and wrap it with the cc::SkiaPaintCanvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Khushal, 2017-03-20 21:57:22]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:03:28]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Khushal, 2017-03-20 22:10:34]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 22:11:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:16:27]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Khushal, 2017-03-20 22:18:57]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 22:19:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:23:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:24:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Khushal, 2017-03-20 22:59:05]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:05:03]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Khushal, 2017-03-20 23:22:32]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:23:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:35:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Khushal, 2017-03-20 23:48:29]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 00:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:03:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Khushal, 2017-03-21 02:33:19]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 02:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 03:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 03:21:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2017-03-21 03:55:52]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 04:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 04:33:49]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Khushal, 2017-03-21 04:49:32]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 04:49:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 05:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 05:31:26]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Khushal, 2017-03-21 05:47:39]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 05:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 05:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 05:55:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Khushal, 2017-03-21 06:59:13]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 06:59:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 11:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 11:07:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2017-03-21 23:54:38]

khushalsagar@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org, esprehn@chromium.org

[Khushal, 2017-03-21 23:54:39]

+enne overall.
+danakj ui/.
+espreshn for everything else.

[Khushal, 2017-03-21 23:55:07]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:55:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2017-03-21 23:56:03]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers now create a SkBitmap, use it to create a raster SkCanvas,
and wrap it with the cc::SkiaPaintCanvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Khushal, 2017-03-21 23:59:11]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Khushal, 2017-03-21 23:59:42]

TBRing for chrome/ and media/ missing includes.

[esprehn, 2017-03-22 00:07:57]

lgtm

[commit-bot: I haz the power, 2017-03-22 00:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:13:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[enne (OOO), 2017-03-22 00:40:59]

enne@chromium.org changed reviewers:
+ vmpstr@chromium.org

[enne (OOO), 2017-03-22 00:41:01]

danakj and vmpstr can weight in here and disagree if they'd like, but I was
hoping to eventually get to better recording vs raster distinctions by removing
functions off PaintCanvas that only made sense for raster, like readPixels or
peekPixels.

I think that would mean that callers should just create their own SkBitmap
(which should just be a one-liner) and wrap it in an SkPaintCanvas.  Then if the
caller needs a bitmap or a pixmap out, then they already have it.

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
File cc/paint/skia_paint_canvas.cc (right):

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
cc/paint/skia_paint_canvas.cc:19: std::unique_ptr<SkiaPaintCanvas>
SkiaPaintCanvas::CreateRasterZeroed(
I'm a little confused about the zeroed part of this.  Is that new?  Over what
the code used to do?

[Khushal, 2017-03-22 00:45:51]

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
File cc/paint/skia_paint_canvas.cc (right):

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
cc/paint/skia_paint_canvas.cc:19: std::unique_ptr<SkiaPaintCanvas>
SkiaPaintCanvas::CreateRasterZeroed(
On 2017/03/22 00:41:01, enne wrote:
> I'm a little confused about the zeroed part of this.  Is that new?  Over what
> the code used to do?

The SkSurface does that, and I had a few tests breaking without it so I assumed
some code that was using gfx::Canvas was relying on it?

I can change call-sites of this function to create a bitmap directly. And only
have the gfx one use zero initialization.

[danakj, 2017-03-22 15:06:51]

On 2017/03/22 00:41:01, enne wrote:
> danakj and vmpstr can weight in here and disagree if they'd like, but I was
> hoping to eventually get to better recording vs raster distinctions by
removing
> functions off PaintCanvas that only made sense for raster, like readPixels or
> peekPixels.
> 
> I think that would mean that callers should just create their own SkBitmap
> (which should just be a one-liner) and wrap it in an SkPaintCanvas.  Then if
the
> caller needs a bitmap or a pixmap out, then they already have it.

Yes same. I've been doing

SkBitmap bitmap;
bitmap.allocN32Pixels(width, height, opaque);
SkCanvas canvas(bitmap);
// if opaque = false:
canvas.clear(SK_ColorTRANSPARENT);

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
File cc/paint/skia_paint_canvas.cc (right):

https://codereview.chromium.org/2764633002/diff/240001/cc/paint/skia_paint_ca...
cc/paint/skia_paint_canvas.cc:19: std::unique_ptr<SkiaPaintCanvas>
SkiaPaintCanvas::CreateRasterZeroed(
On 2017/03/22 00:45:51, Khushal wrote:
> On 2017/03/22 00:41:01, enne wrote:
> > I'm a little confused about the zeroed part of this.  Is that new?  Over
what
> > the code used to do?
> 
> The SkSurface does that, and I had a few tests breaking without it so I
assumed
> some code that was using gfx::Canvas was relying on it?
> 
> I can change call-sites of this function to create a bitmap directly. And only
> have the gfx one use zero initialization.

Can you just have code that makes SkBitmap call SkCanvas::clear() on it directly
if not opaque?

https://codereview.chromium.org/2764633002/diff/240001/ui/gfx/canvas.cc
File ui/gfx/canvas.cc (right):

https://codereview.chromium.org/2764633002/diff/240001/ui/gfx/canvas.cc#newco...
ui/gfx/canvas.cc:36: std::unique_ptr<cc::PaintCanvas> CreateCanvas(const Size&
size,
vmpstr is also changing this code in https://codereview.chromium.org/2758413002/
and I think this would be more coherent after rebasing on top of that.

[Khushal, 2017-03-22 17:19:40]

vmpstr's patch looks like it is making very similar changes to the code. :l
I'll rebase on that, which should reduce the code here to just deleting
PaintSurface.

[Khushal, 2017-03-24 20:17:14]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 20:17:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:33:53]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[Khushal, 2017-03-24 20:58:12]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 20:58:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2017-03-24 21:07:17]

I moved all the bitmap stuff to the callers. PTAL.

[enne (OOO), 2017-03-24 21:10:13]

lgtm

[commit-bot: I haz the power, 2017-03-24 22:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:39:21]

Dry run: This issue passed the CQ dry run.

[Khushal, 2017-03-27 16:59:24]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-03-27 16:59:25]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2764633002/#ps300001
(title: "test")

[commit-bot: I haz the power, 2017-03-27 17:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:11:41]

Failed to apply patch for
third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:4
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp' with
conflicts.
  U third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

Patch:       third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
Index: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
diff --git a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
index
de6f29c6c19b0bb5aa73c49c5985e49343f6cac9..4e6f73b15573cbf94ee37d26ab80f31304cced3c
100644
--- a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
+++ b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
@@ -4,6 +4,7 @@
 
 #include "core/offscreencanvas/OffscreenCanvas.h"
 
+#include <memory>
 #include "core/dom/ExceptionCode.h"
 #include "core/fileapi/Blob.h"
 #include "core/frame/ImageBitmap.h"
@@ -17,8 +18,8 @@
 #include "platform/graphics/OffscreenCanvasFrameDispatcherImpl.h"
 #include "platform/graphics/StaticBitmapImage.h"
 #include "platform/image-encoders/ImageEncoderUtils.h"
+#include "third_party/skia/include/core/SkSurface.h"
 #include "wtf/MathExtras.h"
-#include <memory>
 
 namespace blink {

[Khushal, 2017-03-27 19:21:11]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-03-27 19:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2764633002/#ps320001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-27 19:21:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:55:31]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1490642471207860,
"parent_rev": "625dec950fc94b1678646d4d5ef19b76c49c96db", "commit_rev":
"82843780df15988017b386494f1e76c333410b1d"}

[commit-bot: I haz the power, 2017-03-27 21:56:57]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

[commit-bot: I haz the power, 2017-03-27 21:57:01]

Committed patchset #17 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...

[hbos_chromium, 2017-03-28 08:29:48]

A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.chromium.org/2781823002/ by hbos@chromium.org.

The reason for reverting is: This is likely the culprit causing WebRTC waterfall
to consistently fail with error:

[8593:779:0327/161553.140078:ERROR:video_track_recorder.cc(331)] Error trying to
map PaintSurface's pixels

Sample failure:
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/66456

Recent builds:
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/.

[Khushal, 2017-03-28 20:01:45]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

[Khushal, 2017-03-28 20:51:57]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 20:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2017-03-28 20:57:42]

enne@, do you mind taking another look?
#19 is just the rebase, #20 is the fix for the error.

https://codereview.chromium.org/2764633002/diff/380001/content/renderer/media...
File content/renderer/media_recorder/video_track_recorder.cc (right):

https://codereview.chromium.org/2764633002/diff/380001/content/renderer/media...
content/renderer/media_recorder/video_track_recorder.cc:316: if (!canvas_ ||
canvas_->imageInfo().width() != info.width() ||
The bug was that the bitmap would have the pixels only the first time the
|canvas_| was created.

[commit-bot: I haz the power, 2017-03-28 21:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:16:16]

Dry run: CQ has no permission to schedule in bucket
master.tryserver.chromium.linux

[enne (OOO), 2017-03-29 12:36:58]

lgtm, thanks!

I think the description of this patch is also out of date.

[Khushal, 2017-03-29 18:26:52]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create
a raster canvas.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now create a bitmap to wrap a SkiaPaintCanvas for
raster.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

[Khushal, 2017-03-29 18:27:12]

On 2017/03/29 12:36:58, enne wrote:
> lgtm, thanks!
> 
> I think the description of this patch is also out of date.

Thanks. Done.

[Khushal, 2017-03-29 18:27:20]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-03-29 18:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2764633002/#ps380001
(title: "fix for relanding")

[commit-bot: I haz the power, 2017-03-29 18:28:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:39:46]

CQ is committing da patch.

Bot data: {"patchset_id": 380001, "attempt_start_ts": 1490812040755440,
"parent_rev": "a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28", "commit_rev":
"60900cbcf95fb50ed89330e5d26d5f37f9b845ef"}

[commit-bot: I haz the power, 2017-03-29 18:40:38]

Description was changed from

==========
cc/paint: Remove cc::PaintSurface.

The callers can now create a bitmap to wrap a SkiaPaintCanvas for
raster.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...
==========

to

==========
cc/paint: Remove cc::PaintSurface.

The callers can now create a bitmap to wrap a SkiaPaintCanvas for
raster.

TBR=bauerb@chromium.org,dalecurtis@chromium.org
BUG=703320
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#459894}
Committed:
https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e...

Review-Url: https://codereview.chromium.org/2764633002
Cr-Commit-Position: refs/heads/master@{#460468}
Committed:
https://chromium.googlesource.com/chromium/src/+/60900cbcf95fb50ed89330e5d26d...
==========

[commit-bot: I haz the power, 2017-03-29 18:40:40]

Committed patchset #20 (id:380001) as
https://chromium.googlesource.com/chromium/src/+/60900cbcf95fb50ed89330e5d26d...