Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2781823002: Revert of cc/paint: Remove cc::PaintSurface. (Closed)

Created:
3 years, 9 months ago by hbos_chromium
Modified:
3 years, 9 months ago
CC:
ajuma+watch-canvas_chromium.org, ajuma+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chfremer+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, emircan+watch+mediarecorder_chromium.org, emircan+watch+capturefromdom_chromium.org, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, jam, jbroman, Justin Novosad, kinuko+watch, mcasas+mediarecorder_chromium.org, mcasas+capturefromelement_chromium.org, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc/paint: Remove cc::PaintSurface. (patchset #17 id:320001 of https://codereview.chromium.org/2764633002/ ) Reason for revert: This is likely the culprit causing WebRTC waterfall to consistently fail with error: [8593:779:0327/161553.140078:ERROR:video_track_recorder.cc(331)] Error trying to map PaintSurface's pixels Sample failure: https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/66456 Recent builds: https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/ Original issue's description: > cc/paint: Remove cc::PaintSurface. > > The callers can now use SkiaPaintCanvas::CreateRasterZeroed to create > a raster canvas. > > TBR=bauerb@chromium.org,dalecurtis@chromium.org > BUG=703320 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2764633002 > Cr-Commit-Position: refs/heads/master@{#459894} > Committed: https://chromium.googlesource.com/chromium/src/+/82843780df15988017b386494f1e76c333410b1d TBR=enne@chromium.org,danakj@chromium.org,esprehn@chromium.org,vmpstr@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703320 Review-Url: https://codereview.chromium.org/2781823002 Cr-Commit-Position: refs/heads/master@{#460041} Committed: https://chromium.googlesource.com/chromium/src/+/9fcf58f9b1d0cf15b4bfe49e7c53ef9732d91431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -73 lines) Patch
M cc/paint/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/paint/display_item_list_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A cc/paint/paint_surface.h View 1 chunk +58 lines, -0 lines 0 comments Download
A cc/paint/paint_surface.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_login_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/image_capture/image_capture_frame_grabber.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media_capture_from_element/html_video_element_capturer_source.h View 3 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/media_capture_from_element/html_video_element_capturer_source.cc View 4 chunks +35 lines, -25 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M media/renderers/skcanvas_video_renderer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp View 8 chunks +26 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/PaintSurface.h View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hbos_chromium
Created Revert of cc/paint: Remove cc::PaintSurface.
3 years, 9 months ago (2017-03-28 08:29:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781823002/1
3 years, 9 months ago (2017-03-28 08:30:02 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 08:31:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9fcf58f9b1d0cf15b4bfe49e7c53...

Powered by Google App Engine
This is Rietveld 408576698