cc/paint: Remove cc::PaintSurface.

cc/paint/skia_paint_canvas.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/paint/paint_canvas.h"
 
 #include "base/memory/ptr_util.h"
 #include "cc/paint/display_item_list.h"
 #include "cc/paint/paint_record.h"
 #include "cc/paint/paint_recorder.h"
 #include "third_party/skia/include/core/SkAnnotation.h"
+#include "third_party/skia/include/core/SkMallocPixelRef.h"
 #include "third_party/skia/include/core/SkMetaData.h"
 #include "third_party/skia/include/utils/SkNWayCanvas.h"
 
 namespace cc {
 
+// static
+std::unique_ptr<SkiaPaintCanvas> SkiaPaintCanvas::CreateRasterZeroed(

[enne (OOO), 2017/03/22 00:41:01]

I'm a little confused about the zeroed part of this.  Is that new?  Over what
the code used to do?

[Khushal, 2017/03/22 00:45:51]

The SkSurface does that, and I had a few tests breaking without it so I assumed
some code that was using gfx::Canvas was relying on it?

I can change call-sites of this function to create a bitmap directly. And only
have the gfx one use zero initialization.

[danakj, 2017/03/22 15:06:51]

Can you just have code that makes SkBitmap call SkCanvas::clear() on it directly
if not opaque?

+    const SkImageInfo& info) {
+  sk_sp<SkPixelRef> pr(SkMallocPixelRef::NewZeroed(info, 0, nullptr));
+  if (!pr)
+    return nullptr;
+
+  SkBitmap bitmap;
+  bitmap.setInfo(info, pr->rowBytes());
+  bitmap.setPixelRef(std::move(pr), 0, 0);
+  return base::MakeUnique<SkiaPaintCanvas>(bitmap);
+}
+
 SkiaPaintCanvas::SkiaPaintCanvas(SkCanvas* canvas) : canvas_(canvas) {}
 
 SkiaPaintCanvas::SkiaPaintCanvas(const SkBitmap& bitmap)
     : canvas_(new SkCanvas(bitmap)), owned_(canvas_) {}
 
 SkiaPaintCanvas::SkiaPaintCanvas(const SkBitmap& bitmap,
                                  const SkSurfaceProps& props)
     : canvas_(new SkCanvas(bitmap, props)), owned_(canvas_) {}
 
 SkiaPaintCanvas::~SkiaPaintCanvas() = default;
@@ skipping 297 matching lines @@
                                                SkData* data) {
   SkAnnotateNamedDestination(canvas_, point, data);
 }
 
 void SkiaPaintCanvas::AnnotateLinkToDestination(const SkRect& rect,
                                                 SkData* data) {
   SkAnnotateLinkToDestination(canvas_, rect, data);
 }
 
 }  // namespace cc