Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2764543002: MD Settings: Appearance page: Use home page polish (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Appearance page: Use home page polish * Added 'Disabled' subtext when 'Show home button' toggle is off * Added 'Custom' subtext * Changed 'Use the New Tab Page subtext to 'New Tab page' * Removed 'Other' checkbox label from custom input option * Changed custom input label to 'Enter custom web address' * Made the custom input width 200px BUG=619768 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2764543002 Cr-Commit-Position: refs/heads/master@{#458460} Committed: https://chromium.googlesource.com/chromium/src/+/6e84ac1cc45e551a53b8381068cb91f0263f6b66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 2 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
3 years, 9 months ago (2017-03-20 16:53:39 UTC) #4
Dan Beam
lgtm
3 years, 9 months ago (2017-03-21 05:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764543002/1
3 years, 9 months ago (2017-03-21 16:34:59 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 17:40:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e84ac1cc45e551a53b8381068cb...

Powered by Google App Engine
This is Rietveld 408576698