Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2764543002: MD Settings: Appearance page: Use home page polish (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 032f343682d230d4181ee8b85b474cbde2ea8249..f741a59b07b4c642e7488d0fc6ba9e3e1ba31871 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -25,6 +25,10 @@
.secondary-button ~ .secondary-button {
-webkit-margin-start: 12px;
}
+
+ #customHomePage {
+ width: 200px;
+ }
</style>
<settings-animated-pages id="pages" section="appearance">
<neon-animatable route-path="default">
@@ -96,25 +100,27 @@
pref="{{prefs.browser.show_home_button}}"
label="$i18n{showHomeButton}"
sub-label="[[getShowHomeSubLabel_(
- prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]">
+ prefs.browser.show_home_button.value,
+ prefs.homepage_is_newtabpage.value,
+ prefs.homepage.value)]]">
</settings-toggle-button>
</div>
<template is="dom-if" if="[[prefs.browser.show_home_button.value]]">
- <div class="list-frame"
- hidden="[[!pageVisibility.homeButton]]">
+ <div class="list-frame" hidden="[[!pageVisibility.homeButton]]">
<settings-radio-group pref="{{prefs.homepage_is_newtabpage}}">
<controlled-radio-button class="list-item" name="true"
pref="[[prefs.homepage_is_newtabpage]]"
label="$i18n{homePageNtp}" no-extension-indicator>
</controlled-radio-button>
<controlled-radio-button class="list-item" name="false"
- pref="[[prefs.homepage_is_newtabpage]]" label="$i18n{other}"
+ pref="[[prefs.homepage_is_newtabpage]]"
no-extension-indicator>
<!-- TODO(dbeam): this can show double indicators when both
homepage and whether to use the NTP as the homepage are
managed. -->
- <settings-input no-label-float pref="{{prefs.homepage}}"
- label="$i18n{exampleDotCom}"
+ <settings-input id="customHomePage"
+ no-label-float pref="{{prefs.homepage}}"
+ label="$i18n{enterCustomWebAddress}"
can-tab="[[!prefs.homepage_is_newtabpage.value]]"
stop-keyboard-event-propagation no-extension-indicator>
</settings-input>
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/appearance_page/appearance_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698