Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5594)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2764543002: MD Settings: Appearance page: Use home page polish (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index a258d4687d694be8514b9076b8f892803c740ace..cec64245e5f3368fe3dea9cac644bb4a5402b29d 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -129,15 +129,18 @@ Polymer({
},
/**
+ * @param {boolean} showHomepage Whether to show home page.
* @param {boolean} isNtp Whether to use the NTP as the home page.
- * @param {string} homepage If not using NTP, use this URL.
+ * @param {string} homepageValue If not using NTP, use this URL.
* @return {string} The sub-label.
* @private
*/
- getShowHomeSubLabel_: function(isNtp, homepage) {
+ getShowHomeSubLabel_: function(showHomepage, isNtp, homepageValue) {
+ if (!showHomepage)
+ return this.i18n('homeButtonDisabled');
if (isNtp)
return this.i18n('homePageNtp');
- return homepage || this.i18n('exampleDotCom');
+ return homepageValue || this.i18n('customWebAddress');
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698