[regexp] Named capture support for callable replacements

src/objects.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <memory>
 #include <sstream>
@@ skipping 6554 matching lines @@
       MaybeHandle<Object> result =
           JSObject::DefineAccessor(it, getter, setter, attrs);
       if (result.is_null()) return Nothing<bool>();
     }
   }
 
   // 11. Return true.
   return Just(true);
 }
 
+// static
+Maybe<bool> JSReceiver::CreateDataProperty(Handle<JSReceiver> holder,

[Yang, 2017/03/23 14:58:22]

Does JSObject::AddProperty not fit the purpose? We know that we are dealing with
a new object with null proto after all.

[jgruber, 2017/03/24 14:06:46]

Good point, CreateDataProperty ends up calling that anyways.

+                                           Handle<Object> key,
+                                           Handle<Object> value,
+                                           ShouldThrow should_throw) {
+  Isolate* isolate = holder->GetIsolate();
+  bool success;
+  LookupIterator it = LookupIterator::PropertyOrElement(
+      isolate, holder, key, &success, LookupIterator::OWN);
+  if (!success) return Nothing<bool>();
+  return JSReceiver::CreateDataProperty(&it, value, should_throw);
+}
 
 // static
 Maybe<bool> JSReceiver::CreateDataProperty(LookupIterator* it,
                                            Handle<Object> value,
                                            ShouldThrow should_throw) {
   DCHECK(!it->check_prototype_chain());
   Handle<JSReceiver> receiver = Handle<JSReceiver>::cast(it->GetReceiver());
   Isolate* isolate = receiver->GetIsolate();
 
   if (receiver->IsJSObject()) {
@@ skipping 13711 matching lines @@
       // depend on this.
       return DICTIONARY_ELEMENTS;
     }
     DCHECK_LE(kind, LAST_ELEMENTS_KIND);
     return kind;
   }
 }
 
 }  // namespace internal
 }  // namespace v8