Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2776123002: [string] Refactor String::GetSubstitution (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Refactor String::GetSubstitution Remove deep nesting and repeated code by using a switch-based structure (instead of if-based), use clearer variable names, and separate cleanly between immutable and mutable variables. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2776123002 Cr-Commit-Position: refs/heads/master@{#44147} Committed: https://chromium.googlesource.com/v8/v8/+/fc44d57bcbd8c851e7be6c9513edb6e42cb8c245

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix missing continue_from_ix store #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -38 lines) Patch
M src/objects.cc View 1 2 chunks +64 lines, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
jgruber
Some refactoring prior to named-capture support. As an aside: GetSubstitution is just slow atm (mostly ...
3 years, 9 months ago (2017-03-27 10:47:31 UTC) #4
Yang
On 2017/03/27 10:47:31, jgruber wrote: > Some refactoring prior to named-capture support. > > As ...
3 years, 9 months ago (2017-03-27 13:01:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776123002/20001
3 years, 9 months ago (2017-03-27 13:04:16 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 13:19:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fc44d57bcbd8c851e7be6c9513edb6e42cb...

Powered by Google App Engine
This is Rietveld 408576698