Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2763693002: [Merge to M58]Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58]Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. The regression was introduced in https://codereview.chromium.org/2710053005. We need to make sure the canvas was restored right after the launcher circle icon was drawn. BUG=700449 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2746263002 Cr-Commit-Position: refs/heads/master@{#456730} (cherry picked from commit c582275b87cf75a5467d3afaa74e042baa553b38) Review-Url: https://codereview.chromium.org/2763693002 . Cr-Commit-Position: refs/branch-heads/3029@{#298} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/cb1e0b5de0215a7db18701045029503bf0d479be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 chunk +16 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xdai1
3 years, 9 months ago (2017-03-20 16:48:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb1e0b5de0215a7db18701045029503bf0d479be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698