Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2746263002: Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS: Fix the regression of the broken focus rectangle on Launcher icon. The regression was introduced in https://codereview.chromium.org/2710053005. We need to make sure the canvas was restored right after the launcher circle icon was drawn. BUG=700449 Review-Url: https://codereview.chromium.org/2746263002 Cr-Commit-Position: refs/heads/master@{#456730} Committed: https://chromium.googlesource.com/chromium/src/+/c582275b87cf75a5467d3afaa74e042baa553b38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 chunk +16 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xdai1
oshima@, could you help review this CL please? Thanks!
3 years, 9 months ago (2017-03-13 20:50:25 UTC) #2
oshima
lgtm
3 years, 9 months ago (2017-03-14 12:27:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746263002/1
3 years, 9 months ago (2017-03-14 16:40:33 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:45:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c582275b87cf75a5467d3afaa74e...

Powered by Google App Engine
This is Rietveld 408576698