Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2710053005: Remove non-MD code from AppListButton (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD code from AppListButton BUG=687801 TEST=none Review-Url: https://codereview.chromium.org/2710053005 Cr-Commit-Position: refs/heads/master@{#453633} Committed: https://chromium.googlesource.com/chromium/src/+/616baf0f3549bd07c203fdc7e0fbe1c9a1b1fe6a

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 21 (15 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-24 17:31:24 UTC) #6
oshima
lgtm
3 years, 9 months ago (2017-02-28 01:56:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710053005/1
3 years, 9 months ago (2017-02-28 16:42:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/47090) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-02-28 16:45:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710053005/20001
3 years, 9 months ago (2017-02-28 17:38:40 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 17:44:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/616baf0f3549bd07c203fdc7e0fb...

Powered by Google App Engine
This is Rietveld 408576698