Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2762953004: Remove inline small resource transfer experiment (Closed)

Created:
3 years, 9 months ago by scottmg
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, jam, Ilya Sherman
CC:
chromium-reviews, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org, srahim+watch_chromium.org, mmenke, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove inline small resource transfer experiment This removes the code for an experiment to inline small resources into the main IPC resource. This simplifies some c/b/loader separation, particularly the hooks in async_resource_handler.cc. BUG=580928, 703188 Review-Url: https://codereview.chromium.org/2762953004 Cr-Commit-Position: refs/heads/master@{#458899} Committed: https://chromium.googlesource.com/chromium/src/+/4ecbd1cc3eec2593a082c53367415f6d1b0a6523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -403 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/loader/async_resource_handler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 9 chunks +0 lines, -134 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 72 chunks +63 lines, -135 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher.cc View 5 chunks +0 lines, -37 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
scottmg
jam: content/ isherman: tools/metrics/histograms/histograms.xml tsepez: content/common/resource_messages.h thanks
3 years, 9 months ago (2017-03-22 15:44:55 UTC) #14
jam
lgtm
3 years, 9 months ago (2017-03-22 15:57:06 UTC) #15
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-22 17:15:17 UTC) #16
Ilya Sherman
histograms.xml LGTM
3 years, 9 months ago (2017-03-22 22:19:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762953004/1
3 years, 9 months ago (2017-03-22 22:20:35 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 22:29:40 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ecbd1cc3eec2593a082c5336741...

Powered by Google App Engine
This is Rietveld 408576698