Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: content/browser/loader/async_resource_handler_unittest.cc

Issue 2762953004: Remove inline small resource transfer experiment (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/async_resource_handler.h" 5 #include "content/browser/loader/async_resource_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 ResourceMsg_RequestComplete::Param completion_params; 266 ResourceMsg_RequestComplete::Param completion_params;
267 ResourceMsg_RequestComplete::Read(messages[3].get(), &completion_params); 267 ResourceMsg_RequestComplete::Read(messages[3].get(), &completion_params);
268 ResourceRequestCompletionStatus completion_status = 268 ResourceRequestCompletionStatus completion_status =
269 std::get<1>(completion_params); 269 std::get<1>(completion_params);
270 270
271 EXPECT_EQ(TotalReceivedBytes(kDataSize), 271 EXPECT_EQ(TotalReceivedBytes(kDataSize),
272 completion_status.encoded_data_length); 272 completion_status.encoded_data_length);
273 EXPECT_EQ(kDataSize, completion_status.encoded_body_length); 273 EXPECT_EQ(kDataSize, completion_status.encoded_body_length);
274 } 274 }
275 275
276 TEST_F(AsyncResourceHandlerTest, InlinedChunkLengths) {
277 // TODO(ricea): Remove this Feature-enabling code once the feature is on by
278 // default.
279 base::test::ScopedFeatureList scoped_feature_list;
280 scoped_feature_list.InitAndEnableFeature(
281 features::kOptimizeLoadingIPCForSmallResources);
282
283 // Smaller than kInlinedLeadingChunkSize.
284 constexpr auto kDataSize = 8;
285 StartRequestAndWaitWithResponseDataSize(kDataSize);
286 const auto& messages = filter_->messages();
287 ASSERT_EQ(3u, messages.size());
288 ASSERT_EQ(ResourceMsg_InlinedDataChunkReceived::ID, messages[1]->type());
289 ResourceMsg_InlinedDataChunkReceived::Param params;
290 ResourceMsg_InlinedDataChunkReceived::Read(messages[1].get(), &params);
291
292 int encoded_data_length = std::get<2>(params);
293 EXPECT_EQ(kDataSize, encoded_data_length);
294
295 ASSERT_EQ(ResourceMsg_RequestComplete::ID, messages[2]->type());
296 ResourceMsg_RequestComplete::Param completion_params;
297 ResourceMsg_RequestComplete::Read(messages[2].get(), &completion_params);
298 ResourceRequestCompletionStatus completion_status =
299 std::get<1>(completion_params);
300
301 EXPECT_EQ(TotalReceivedBytes(kDataSize),
302 completion_status.encoded_data_length);
303 EXPECT_EQ(kDataSize, completion_status.encoded_body_length);
304 }
305
306 TEST_F(AsyncResourceHandlerTest, TwoChunksLengths) { 276 TEST_F(AsyncResourceHandlerTest, TwoChunksLengths) {
307 // Larger than kMaxAllocationSize. 277 // Larger than kMaxAllocationSize.
308 constexpr auto kDataSize = 64 * 1024; 278 constexpr auto kDataSize = 64 * 1024;
309 StartRequestAndWaitWithResponseDataSize(kDataSize); 279 StartRequestAndWaitWithResponseDataSize(kDataSize);
310 const auto& messages = filter_->messages(); 280 const auto& messages = filter_->messages();
311 ASSERT_EQ(5u, messages.size()); 281 ASSERT_EQ(5u, messages.size());
312 ASSERT_EQ(ResourceMsg_DataReceived::ID, messages[2]->type()); 282 ASSERT_EQ(ResourceMsg_DataReceived::ID, messages[2]->type());
313 ResourceMsg_DataReceived::Param params; 283 ResourceMsg_DataReceived::Param params;
314 ResourceMsg_DataReceived::Read(messages[2].get(), &params); 284 ResourceMsg_DataReceived::Read(messages[2].get(), &params);
315 285
(...skipping 12 matching lines...) Expand all
328 ResourceRequestCompletionStatus completion_status = 298 ResourceRequestCompletionStatus completion_status =
329 std::get<1>(completion_params); 299 std::get<1>(completion_params);
330 EXPECT_EQ(TotalReceivedBytes(kDataSize), 300 EXPECT_EQ(TotalReceivedBytes(kDataSize),
331 completion_status.encoded_data_length); 301 completion_status.encoded_data_length);
332 EXPECT_EQ(kDataSize, completion_status.encoded_body_length); 302 EXPECT_EQ(kDataSize, completion_status.encoded_body_length);
333 } 303 }
334 304
335 } // namespace 305 } // namespace
336 306
337 } // namespace content 307 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698