Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/loader/async_resource_handler_unittest.cc

Issue 2762953004: Remove inline small resource transfer experiment (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/async_resource_handler_unittest.cc
diff --git a/content/browser/loader/async_resource_handler_unittest.cc b/content/browser/loader/async_resource_handler_unittest.cc
index 293ca9993aa233ccb31d362e3bd161a24be79a2b..8d681cd8e20878ff7e64c6a7add58b6f840a3901 100644
--- a/content/browser/loader/async_resource_handler_unittest.cc
+++ b/content/browser/loader/async_resource_handler_unittest.cc
@@ -273,36 +273,6 @@ TEST_F(AsyncResourceHandlerTest, OneChunkLengths) {
EXPECT_EQ(kDataSize, completion_status.encoded_body_length);
}
-TEST_F(AsyncResourceHandlerTest, InlinedChunkLengths) {
- // TODO(ricea): Remove this Feature-enabling code once the feature is on by
- // default.
- base::test::ScopedFeatureList scoped_feature_list;
- scoped_feature_list.InitAndEnableFeature(
- features::kOptimizeLoadingIPCForSmallResources);
-
- // Smaller than kInlinedLeadingChunkSize.
- constexpr auto kDataSize = 8;
- StartRequestAndWaitWithResponseDataSize(kDataSize);
- const auto& messages = filter_->messages();
- ASSERT_EQ(3u, messages.size());
- ASSERT_EQ(ResourceMsg_InlinedDataChunkReceived::ID, messages[1]->type());
- ResourceMsg_InlinedDataChunkReceived::Param params;
- ResourceMsg_InlinedDataChunkReceived::Read(messages[1].get(), &params);
-
- int encoded_data_length = std::get<2>(params);
- EXPECT_EQ(kDataSize, encoded_data_length);
-
- ASSERT_EQ(ResourceMsg_RequestComplete::ID, messages[2]->type());
- ResourceMsg_RequestComplete::Param completion_params;
- ResourceMsg_RequestComplete::Read(messages[2].get(), &completion_params);
- ResourceRequestCompletionStatus completion_status =
- std::get<1>(completion_params);
-
- EXPECT_EQ(TotalReceivedBytes(kDataSize),
- completion_status.encoded_data_length);
- EXPECT_EQ(kDataSize, completion_status.encoded_body_length);
-}
-
TEST_F(AsyncResourceHandlerTest, TwoChunksLengths) {
// Larger than kMaxAllocationSize.
constexpr auto kDataSize = 64 * 1024;
« no previous file with comments | « content/browser/loader/async_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698