Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2762643003: Move ContentSuggestions identifiers to custom target (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by gambard
Modified:
6 months, 1 week ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ContentSuggestions identifiers to custom target This CL moves the identifier used in ContentSuggestions to a custom target, allowing an easier include in future refactoring. BUG=694159 Review-Url: https://codereview.chromium.org/2762643003 Cr-Commit-Position: refs/heads/master@{#458105} Committed: https://chromium.googlesource.com/chromium/src/+/be5b17ba520de8c5ebf31d4c4dfac8be44a50366

Patch Set 1 #

Patch Set 2 : Fix includes #

Total comments: 10

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -272 lines) Patch
M ios/chrome/browser/content_suggestions/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/BUILD.gn View 1 2 4 chunks +1 line, -5 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestion.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestion.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier.mm View 1 chunk +0 lines, -36 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestion_identifier_unittest.mm View 1 chunk +0 lines, -92 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.h View 1 chunk +0 lines, -54 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.mm View 1 chunk +0 lines, -30 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/ui/content_suggestions/identifier/BUILD.gn View 1 1 chunk +28 lines, -0 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h View 1 3 chunks +3 lines, -8 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm View 1 2 chunks +1 line, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
gambard
PTAL. I have moved the identifiers to a specific target because I was not happy ...
6 months, 1 week ago (2017-03-20 14:30:43 UTC) #2
lpromero
https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/BUILD.gn File ios/chrome/browser/ui/content_suggestions/BUILD.gn (right): https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/BUILD.gn#newcode47 ios/chrome/browser/ui/content_suggestions/BUILD.gn:47: "//ios/chrome/browser/ui/content_suggestions/identifier", On 2017/03/20 14:30:43, gambard wrote: > I have ...
6 months, 1 week ago (2017-03-20 15:16:02 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/BUILD.gn File ios/chrome/browser/ui/content_suggestions/BUILD.gn (right): https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/BUILD.gn#newcode47 ios/chrome/browser/ui/content_suggestions/BUILD.gn:47: "//ios/chrome/browser/ui/content_suggestions/identifier", On 2017/03/20 15:16:01, lpromero wrote: > ...
6 months, 1 week ago (2017-03-20 15:35:15 UTC) #4
lpromero
https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm File ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm (left): https://codereview.chromium.org/2762643003/diff/20001/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm#oldcode15 ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm:15: @synthesize emptyCell = _emptyCell; On 2017/03/20 15:35:15, gambard wrote: ...
6 months, 1 week ago (2017-03-20 15:42:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762643003/40001
6 months, 1 week ago (2017-03-20 15:43:03 UTC) #7
commit-bot: I haz the power
6 months, 1 week ago (2017-03-20 17:15:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be5b17ba520de8c5ebf31d4c4dfa...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b