Move ContentSuggestions identifiers to custom target

ios/chrome/browser/ui/content_suggestions/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 source_set("content_suggestions") {
   configs += [ "//build/config/compiler:enable_arc" ]
   sources = [
     "content_suggestion.h",
     "content_suggestion.mm",
-    "content_suggestion_identifier.h",
-    "content_suggestion_identifier.mm",
     "content_suggestions_article_item.h",
     "content_suggestions_article_item.mm",
     "content_suggestions_collection_updater.h",
     "content_suggestions_collection_updater.mm",
     "content_suggestions_commands.h",
     "content_suggestions_data_sink.h",
     "content_suggestions_data_source.h",
     "content_suggestions_expandable_item.h",
     "content_suggestions_expandable_item.mm",
     "content_suggestions_favicon_internal_cell.h",
     "content_suggestions_favicon_internal_cell.mm",
     "content_suggestions_favicon_item.h",
     "content_suggestions_favicon_item.mm",
     "content_suggestions_footer_item.h",
     "content_suggestions_footer_item.mm",
     "content_suggestions_image_fetcher.h",
-    "content_suggestions_section_information.h",
-    "content_suggestions_section_information.mm",
     "content_suggestions_stack_item.h",
     "content_suggestions_stack_item.mm",
     "content_suggestions_stack_item_actions.h",
     "content_suggestions_text_item.h",
     "content_suggestions_text_item.mm",
     "content_suggestions_text_item_actions.h",
     "content_suggestions_view_controller.h",
     "content_suggestions_view_controller.mm",
     "expandable_item.h",
   ]
   deps = [
     "//base",
     "//ios/chrome/browser/ui",
     "//ios/chrome/browser/ui/collection_view",
     "//ios/chrome/browser/ui/colors",
     "//ios/chrome/browser/ui/util",
     "//ios/third_party/material_roboto_font_loader_ios",
     "//ui/base",
     "//url",
   ]
   public_deps = [
+    "//ios/chrome/browser/ui/content_suggestions/identifier",

[gambard, 2017/03/20 14:30:43]

I have added it as public deps because I don't see a use case where you could
add the content_suggestions target without adding the identifier target. I am
willing to reconsider if you think this is a bad pattern.

[lpromero, 2017/03/20 15:16:01]

I asked sdefresne. The pattern is to add to deps. Every client that will need to
use identifier will just add it to deps.
From sdefresne: "when in doubt, just do like //base with regard to
deps/public_deps".

[gambard, 2017/03/20 15:35:15]

Ok, thanks!

     "//ios/third_party/material_components_ios",
   ]
 }
 
 source_set("unit_tests") {
   configs += [ "//build/config/compiler:enable_arc" ]
   testonly = true
   sources = [
-    "content_suggestion_identifier_unittest.mm",
     "content_suggestions_article_item_unittest.mm",
     "content_suggestions_expandable_item_unittest.mm",
     "content_suggestions_favicon_item_unittest.mm",
     "content_suggestions_footer_item_unittest.mm",
     "content_suggestions_stack_item_unittest.mm",
     "content_suggestions_text_item_unittest.mm",
   ]
   deps = [
     ":content_suggestions",
     "//base",
     "//ios/chrome/browser/ui/collection_view",
     "//testing/gtest",
     "//third_party/ocmock",
     "//url",
   ]
 }