Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.mm

Issue 2762643003: Move ContentSuggestions identifiers to custom target (Closed)
Patch Set: Fix includes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_section_i nformation.h" 5 #import "ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion s_section_information.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 #if !defined(__has_feature) || !__has_feature(objc_arc) 9 #if !defined(__has_feature) || !__has_feature(objc_arc)
10 #error "This file requires ARC support." 10 #error "This file requires ARC support."
11 #endif 11 #endif
12 12
13 @implementation ContentSuggestionsSectionInformation 13 @implementation ContentSuggestionsSectionInformation
14 14
15 @synthesize emptyCell = _emptyCell;
lpromero 2017/03/20 15:16:01 This was unused?
gambard 2017/03/20 15:35:15 Yes. I will add a title/subtitle string for the em
lpromero 2017/03/20 15:42:08 Definitely. Thanks! lgtm
16 @synthesize layout = _layout; 15 @synthesize layout = _layout;
17 @synthesize sectionID = _sectionID; 16 @synthesize sectionID = _sectionID;
18 @synthesize title = _title; 17 @synthesize title = _title;
19 @synthesize footerTitle = _footerTitle; 18 @synthesize footerTitle = _footerTitle;
20 19
21 - (instancetype)initWithSectionID:(ContentSuggestionsSectionID)sectionID { 20 - (instancetype)initWithSectionID:(ContentSuggestionsSectionID)sectionID {
22 self = [super init]; 21 self = [super init];
23 if (self) { 22 if (self) {
24 DCHECK(sectionID < ContentSuggestionsSectionUnknown); 23 DCHECK(sectionID < ContentSuggestionsSectionUnknown);
25 _sectionID = sectionID; 24 _sectionID = sectionID;
26 } 25 }
27 return self; 26 return self;
28 } 27 }
29 28
30 @end 29 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698