Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2761623002: Clarify comments and code in webkitpy.common.find_files. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify comments and code in webkitpy.common.find_files. Reason: I was looking at this piece of code to see what it does, and made this CL to better understand what it does. In this CL: - Simplify module docstring. - Expand find() docstring. - Add test with example invocation of find(). Review-Url: https://codereview.chromium.org/2761623002 Cr-Commit-Position: refs/heads/master@{#458951} Committed: https://chromium.googlesource.com/chromium/src/+/dcf957a9f996b63113bffa8dad3c5a6382823a28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -25 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py View 5 chunks +19 lines, -22 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py View 3 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 9 months ago (2017-03-20 19:37:41 UTC) #4
jeffcarp
lgtm
3 years, 9 months ago (2017-03-22 22:51:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761623002/1
3 years, 9 months ago (2017-03-22 23:11:47 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:26:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcf957a9f996b63113bffa8dad3c...

Powered by Google App Engine
This is Rietveld 408576698