Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

Issue 2761623002: Clarify comments and code in webkitpy.common.find_files. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
index 15e1f4e3f2d7a3b12527809d7698e27190e8a131..6ebc32683a3b74d276b0c16e41d0706914d330f2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py
@@ -31,6 +31,7 @@ import unittest
from webkitpy.common import find_files
from webkitpy.common.system.filesystem import FileSystem
+from webkitpy.common.system.filesystem_mock import MockFileSystem
class MockWinFileSystem(object):
@@ -45,9 +46,10 @@ class MockWinFileSystem(object):
class TestWinNormalize(unittest.TestCase):
def assert_filesystem_normalizes(self, filesystem):
- self.assertEqual(find_files._normalize(filesystem, "c:\\foo",
- ['fast/html', 'fast/canvas/*', 'compositing/foo.html']),
- ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c:\\foo\\compositing\\foo.html'])
+ # pylint: disable=protected-access
+ self.assertEqual(
+ find_files._normalize(filesystem, 'c:\\foo', ['fast/html', 'fast/canvas/*', 'compositing/foo.html']),
+ ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c:\\foo\\compositing\\foo.html'])
def test_mocked_win(self):
# This tests test_files.normalize, using portable behavior emulating
@@ -61,3 +63,17 @@ class TestWinNormalize(unittest.TestCase):
if sys.platform != 'win32':
return
self.assert_filesystem_normalizes(FileSystem())
+
+
+class TestFind(unittest.TestCase):
+
+ def test_basic(self):
+ filesystem = MockFileSystem({
+ '/base/a/1': '',
+ '/base/a/2': '',
+ '/base/b/1': '',
+ '/base/c/2': '',
+ })
+ self.assertEqual(list(find_files.find(filesystem, '/base/', ['a'])), ['/base/a/1', '/base/a/2'])
+ self.assertEqual(list(find_files.find(filesystem, '/base/', ['b', 'c'])), ['/base/b/1', '/base/c/2'])
+ self.assertEqual(list(find_files.find(filesystem, '/base/', ['*/1'])), ['/base/a/1', '/base/b/1'])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698