Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

Issue 2761623002: Clarify comments and code in webkitpy.common.find_files. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 13 matching lines...) Expand all
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import sys 29 import sys
30 import unittest 30 import unittest
31 31
32 from webkitpy.common import find_files 32 from webkitpy.common import find_files
33 from webkitpy.common.system.filesystem import FileSystem 33 from webkitpy.common.system.filesystem import FileSystem
34 from webkitpy.common.system.filesystem_mock import MockFileSystem
34 35
35 36
36 class MockWinFileSystem(object): 37 class MockWinFileSystem(object):
37 38
38 def join(self, *paths): 39 def join(self, *paths):
39 return '\\'.join(paths) 40 return '\\'.join(paths)
40 41
41 def normpath(self, path): 42 def normpath(self, path):
42 return path.replace('/', '\\') 43 return path.replace('/', '\\')
43 44
44 45
45 class TestWinNormalize(unittest.TestCase): 46 class TestWinNormalize(unittest.TestCase):
46 47
47 def assert_filesystem_normalizes(self, filesystem): 48 def assert_filesystem_normalizes(self, filesystem):
48 self.assertEqual(find_files._normalize(filesystem, "c:\\foo", 49 # pylint: disable=protected-access
49 ['fast/html', 'fast/canvas/*', 'c ompositing/foo.html']), 50 self.assertEqual(
50 ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c: \\foo\\compositing\\foo.html']) 51 find_files._normalize(filesystem, 'c:\\foo', ['fast/html', 'fast/can vas/*', 'compositing/foo.html']),
52 ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c:\\foo\\compos iting\\foo.html'])
51 53
52 def test_mocked_win(self): 54 def test_mocked_win(self):
53 # This tests test_files.normalize, using portable behavior emulating 55 # This tests test_files.normalize, using portable behavior emulating
54 # what we think Windows is supposed to do. This test will run on all 56 # what we think Windows is supposed to do. This test will run on all
55 # platforms. 57 # platforms.
56 self.assert_filesystem_normalizes(MockWinFileSystem()) 58 self.assert_filesystem_normalizes(MockWinFileSystem())
57 59
58 def test_win(self): 60 def test_win(self):
59 # This tests the actual windows platform, to ensure we get the same 61 # This tests the actual windows platform, to ensure we get the same
60 # results that we get in test_mocked_win(). 62 # results that we get in test_mocked_win().
61 if sys.platform != 'win32': 63 if sys.platform != 'win32':
62 return 64 return
63 self.assert_filesystem_normalizes(FileSystem()) 65 self.assert_filesystem_normalizes(FileSystem())
66
67
68 class TestFind(unittest.TestCase):
69
70 def test_basic(self):
71 filesystem = MockFileSystem({
72 '/base/a/1': '',
73 '/base/a/2': '',
74 '/base/b/1': '',
75 '/base/c/2': '',
76 })
77 self.assertEqual(list(find_files.find(filesystem, '/base/', ['a'])), ['/ base/a/1', '/base/a/2'])
78 self.assertEqual(list(find_files.find(filesystem, '/base/', ['b', 'c'])) , ['/base/b/1', '/base/c/2'])
79 self.assertEqual(list(find_files.find(filesystem, '/base/', ['*/1'])), [ '/base/a/1', '/base/b/1'])
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698