Fixing reporting of AMP page load information

Fixing reporting of AMP/previews page load information

AMP page load information is skewed based on checking the wrong event's
foreground state. I am re-versioning the UMA because the new UMA will be
vastly different based on this bug.

This bug applies to previews as well, but the UMA does not need re-versioning.

BUG=703696
Review-Url: https://codereview.chromium.org/2761353002
Cr-Commit-Position: refs/heads/master@{#460014}
Committed: https://chromium.googlesource.com/chromium/src/+/5d2208ce695e4352801e8cb2578ea86b22de9707

[RyanSturm, 2017-03-21 17:18:43]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 17:19:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 18:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 18:34:39]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-03-21 19:10:54]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2017-03-21 19:11:39]

Description was changed from

==========
Fixing reporting of AMP page load information

AMP page load information is skewed based on checking the wrong event's
foreground state. I am reversioning the UMA because the new UMA will be
vastly different based on this bug.

BUG=703696
==========

to

==========
Fixing reporting of AMP/previews page load information

AMP page load information is skewed based on checking the wrong event's
foreground state. I am re-versioning the UMA because the new UMA will be
vastly different based on this bug.

This bug applies to previews as well, but the UMA does not need re-versioning.

BUG=703696
==========

[commit-bot: I haz the power, 2017-03-21 19:11:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:37:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[RyanSturm, 2017-03-21 20:46:03]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 20:46:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 21:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:46:59]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-03-21 23:06:57]

ryansturm@chromium.org changed reviewers:
+ bmcquade@chromium.org

[RyanSturm, 2017-03-21 23:06:58]

bmcquade: PTAL, let me know if you think this should wait until child frames are
supported.

[Charlie Harrison, 2017-03-22 01:39:16]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-03-22 01:39:17]

drive-by: Why not AmpCache2? That a pretty common way of versioning metrics.
"Load" does not really add much information in the already long metric names.

[RyanSturm, 2017-03-22 01:40:20]

On 2017/03/22 01:39:17, Charlie Harrison wrote:
> drive-by: Why not AmpCache2? That a pretty common way of versioning metrics.
> "Load" does not really add much information in the already long metric names.

Sgtm. I was going to ask asvitkine the convention, but *2 seems common enough.

[RyanSturm, 2017-03-22 19:01:47]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:02:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:42:20]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-03-24 17:18:10]

lgtm

[RyanSturm, 2017-03-27 15:56:08]

ryansturm@chromium.org changed reviewers:
+ rkaplow@chromium.org

[RyanSturm, 2017-03-27 15:56:08]

rkaplow: PTAL @ histograms (re-versioning AMP UMA, previews UMA shouldn't need
to be re-versioned)

[rkaplow, 2017-03-28 03:00:52]

lgtm

[RyanSturm, 2017-03-28 03:35:04]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:45:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490672104280090,
"parent_rev": "642318401fc47bea352b860ab8786854abb7c314", "commit_rev":
"5d2208ce695e4352801e8cb2578ea86b22de9707"}

[commit-bot: I haz the power, 2017-03-28 04:46:12]

Description was changed from

==========
Fixing reporting of AMP/previews page load information

AMP page load information is skewed based on checking the wrong event's
foreground state. I am re-versioning the UMA because the new UMA will be
vastly different based on this bug.

This bug applies to previews as well, but the UMA does not need re-versioning.

BUG=703696
==========

to

==========
Fixing reporting of AMP/previews page load information

AMP page load information is skewed based on checking the wrong event's
foreground state. I am re-versioning the UMA because the new UMA will be
vastly different based on this bug.

This bug applies to previews as well, but the UMA does not need re-versioning.

BUG=703696

Review-Url: https://codereview.chromium.org/2761353002
Cr-Commit-Position: refs/heads/master@{#460014}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d2208ce695e4352801e8cb2578e...
==========

[commit-bot: I haz the power, 2017-03-28 04:46:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d2208ce695e4352801e8cb2578e...