Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4917)

Unified Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

Issue 2761353002: Fixing reporting of AMP page load information (Closed)
Patch Set: changed re-verrsioning to AMPCache2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
index 0475ec583ec0799a0dd6d0d78ae423cdbbf00421..be0b59a58f04c89539b47b1149e8fd82b4dfa20a 100644
--- a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
@@ -75,8 +75,8 @@ void PreviewsPageLoadMetricsObserver::OnDomContentLoadedEventStart(
void PreviewsPageLoadMetricsObserver::OnLoadEventStart(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- if (!WasStartedInForegroundOptionalEventInForeground(
- timing.dom_content_loaded_event_start, info)) {
+ if (!WasStartedInForegroundOptionalEventInForeground(timing.load_event_start,
+ info)) {
return;
}
PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsLoadEventFired,
@@ -86,8 +86,8 @@ void PreviewsPageLoadMetricsObserver::OnLoadEventStart(
void PreviewsPageLoadMetricsObserver::OnFirstLayout(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- if (!WasStartedInForegroundOptionalEventInForeground(
- timing.dom_content_loaded_event_start, info)) {
+ if (!WasStartedInForegroundOptionalEventInForeground(timing.first_layout,
+ info)) {
return;
}
PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstLayout,
@@ -98,7 +98,7 @@ void PreviewsPageLoadMetricsObserver::OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.dom_content_loaded_event_start, info)) {
+ timing.first_contentful_paint, info)) {
return;
}
PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsFirstContentfulPaint,
@@ -108,8 +108,8 @@ void PreviewsPageLoadMetricsObserver::OnFirstContentfulPaint(
void PreviewsPageLoadMetricsObserver::OnParseStart(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- if (!WasStartedInForegroundOptionalEventInForeground(
- timing.dom_content_loaded_event_start, info)) {
+ if (!WasStartedInForegroundOptionalEventInForeground(timing.parse_start,
+ info)) {
return;
}
PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsParseStart,

Powered by Google App Engine
This is Rietveld 408576698