chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc - Issue 2761353002: Fixing reporting of AMP page load information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc

Issue 2761353002: Fixing reporting of AMP page load information (Closed)

Patch Set: changed re-verrsioning to AMPCache2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc

index a4748f8f7e2f362fa53b076226cf6f838dac43ad..eae1092739f32a39173fc1a487806da6bae78113 100644

--- a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc

@@ -41,21 +41,22 @@ class AMPPageLoadMetricsObserverTest

void ValidateHistograms(bool expect_histograms) {

ValidateHistogramsFor(

- "PageLoad.Clients.AMPCache.DocumentTiming."

+ "PageLoad.Clients.AMPCache2.DocumentTiming."

"NavigationToDOMContentLoadedEventFired",

timing_.dom_content_loaded_event_start, expect_histograms);

ValidateHistogramsFor(

- "PageLoad.Clients.AMPCache.DocumentTiming.NavigationToFirstLayout",

+ "PageLoad.Clients.AMPCache2.DocumentTiming.NavigationToFirstLayout",

timing_.first_layout, expect_histograms);

ValidateHistogramsFor(

- "PageLoad.Clients.AMPCache.DocumentTiming.NavigationToLoadEventFired",

+ "PageLoad.Clients.AMPCache2.DocumentTiming."

+ "NavigationToLoadEventFired",

timing_.load_event_start, expect_histograms);

ValidateHistogramsFor(

- "PageLoad.Clients.AMPCache.PaintTiming."

+ "PageLoad.Clients.AMPCache2.PaintTiming."

"NavigationToFirstContentfulPaint",

timing_.first_contentful_paint, expect_histograms);

ValidateHistogramsFor(

- "PageLoad.Clients.AMPCache.ParseTiming.NavigationToParseStart",

+ "PageLoad.Clients.AMPCache2.ParseTiming.NavigationToParseStart",

timing_.parse_start, expect_histograms);

}