ChromeOS: Expose 'device type' signal

ChromeOS: Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
Review-Url: https://codereview.chromium.org/2761263007
Cr-Commit-Position: refs/heads/master@{#458973}
Committed: https://chromium.googlesource.com/chromium/src/+/209f4397c58d883b3d8bbbdacf53425c07f434e5

[Wenzhao (Colin) Zang, 2017-03-21 22:04:00]

wzang@chromium.org changed reviewers:
+ alemate@chromium.org, rdevlin.cronin@chromium.org, tbarzic@chromium.org

[Wenzhao (Colin) Zang, 2017-03-21 22:04:01]

@rdevlin.cronin
Please see chrome/common/extensions/api/chromeos_info_private.json

@tbarzic
Please see the rest of the files.

Thanks so much.

[Wenzhao (Colin) Zang, 2017-03-21 22:52:45]

Description was changed from

==========
Expose 'device type' signal

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Alexander Alekseev, 2017-03-22 09:28:12]

Please, make your CL description conform to
https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list...

[Alexander Alekseev, 2017-03-22 09:31:26]

lgtm with nit.

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/info_private_apitest.cc (right):

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/info_private_apitest.cc:39:
base::StringPrintf("DEVICETYPE=%s", device_type.c_str());
const std::string lsb_release = std::string("DEVICETYPE=") + device_type;

[tbarzic, 2017-03-22 16:42:19]

lgtm

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/info_private_apitest.cc (right):

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/info_private_apitest.cc:123: "unknown device
type"))
just "unknown"?

[Devlin, 2017-03-22 22:49:43]

chrome/common/extensions/api/chromeos_info_private.json lgtm

[Wenzhao (Colin) Zang, 2017-03-23 00:28:48]

The CQ bit was checked by wzang@chromium.org

[Wenzhao (Colin) Zang, 2017-03-23 00:28:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, rdevlin.cronin@chromium.org, tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/2761263007/#ps20001
(title: "replace StringPrintf with string")

[commit-bot: I haz the power, 2017-03-23 00:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2017-03-23 00:52:49]

The CQ bit was unchecked by alemate@chromium.org

[Alexander Alekseev, 2017-03-23 00:53:12]

not lgtm.

Coul you fix CL description?

[Wenzhao (Colin) Zang, 2017-03-23 01:09:15]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. 

If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:09:49]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. 

If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:10:17]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. 
If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:10:48]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' were added recently. 
If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' 
were added recently. 
If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:11:23]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' 
were added recently. 
If the device type is 'unknown', return 'chromedevice' instead, otherwise return
the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' 
were added recently. If the device type is 'unknown', return 
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:12:11]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 'managed
device' 
were added recently. If the device type is 'unknown', return 
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:12:26]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', return
'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:17:17]

The description is updated.

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/info_private_apitest.cc (right):

https://codereview.chromium.org/2761263007/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/info_private_apitest.cc:39:
base::StringPrintf("DEVICETYPE=%s", device_type.c_str());
On 2017/03/22 09:31:26, Alexander Alekseev wrote:
> const std::string lsb_release = std::string("DEVICETYPE=") + device_type;

Done.

[Alexander Alekseev, 2017-03-23 01:18:08]

lgtm

[Wenzhao (Colin) Zang, 2017-03-23 01:19:26]

Description was changed from

==========
Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
ChromeOS: Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

[Wenzhao (Colin) Zang, 2017-03-23 01:21:14]

The CQ bit was checked by wzang@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:51:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490232074094150,
"parent_rev": "5786cea1a61ebae48b4635bf89544038f9fa4455", "commit_rev":
"209f4397c58d883b3d8bbbdacf53425c07f434e5"}

[commit-bot: I haz the power, 2017-03-23 01:52:29]

Description was changed from

==========
ChromeOS: Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772
==========

to

==========
ChromeOS: Expose 'device type' signal

For use by the Get Help app, similar to how the 'playstore status' and 
'managed device' were added recently. If the device type is 'unknown', 
return 'chromedevice' instead, otherwise return the device type unchanged.

BUG=702772

Review-Url: https://codereview.chromium.org/2761263007
Cr-Commit-Position: refs/heads/master@{#458973}
Committed:
https://chromium.googlesource.com/chromium/src/+/209f4397c58d883b3d8bbbdacf53...
==========

[commit-bot: I haz the power, 2017-03-23 01:52:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/209f4397c58d883b3d8bbbdacf53...