ChromeOS: Expose 'device type' signal

chrome/browser/chromeos/extensions/info_private_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/sys_info.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/stub_install_attributes.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/settings/cros_settings_names.h"
 #include "components/arc/arc_util.h"
@@ skipping 10 matching lines @@
   ChromeOSInfoPrivateTest() {}
   ~ChromeOSInfoPrivateTest() override {}
 
  protected:
   void EnableKioskSession() {
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kForceAppMode);
     base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kAppId,
                                                               kTestAppId);
   }
+
+  void SetDeviceType(const std::string& device_type) {
+    const std::string lsb_release =
+        base::StringPrintf("DEVICETYPE=%s", device_type.c_str());

[Alexander Alekseev, 2017/03/22 09:31:26]

const std::string lsb_release = std::string("DEVICETYPE=") + device_type;

[Wenzhao (Colin) Zang, 2017/03/23 01:17:16]

Done.

+    base::SysInfo::SetChromeOSVersionInfoForTest(lsb_release,
+                                                 base::Time::Now());
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, TestGetAndSet) {
   // Set the initial timezone different from what JS function
   // timezoneSetTest() will attempt to set.
   base::Value initial_timezone("America/Los_Angeles");
   chromeos::CrosSettings::Get()->Set(chromeos::kSystemTimezone,
                                      initial_timezone);
 
   // Check that accessibility settings are set to default values.
@@ skipping 30 matching lines @@
       RunPlatformAppTestWithArg("chromeos_info_private/extended", "kiosk"))
       << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, ArcNotAvailable) {
   ASSERT_TRUE(RunPlatformAppTestWithArg("chromeos_info_private/extended",
                                         "arc not-available"))
       << message_;
 }
 
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebase) {
+  SetDeviceType("CHROMEBASE");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebase"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebit) {
+  SetDeviceType("CHROMEBIT");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebit"))
+      << message_;
+}
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebook) {
+  SetDeviceType("CHROMEBOOK");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebook"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebox) {
+  SetDeviceType("CHROMEBOX");
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebox"))
+      << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, UnknownDeviceType) {
+  SetDeviceType("UNKNOWN");
+  ASSERT_TRUE(RunPlatformAppTestWithArg("chromeos_info_private/extended",
+                                        "unknown device type"))

[tbarzic, 2017/03/22 16:42:19]

just "unknown"?

+      << message_;
+}
+
 class ChromeOSArcInfoPrivateTest : public ChromeOSInfoPrivateTest {
  public:
   ChromeOSArcInfoPrivateTest() = default;
   ~ChromeOSArcInfoPrivateTest() override = default;
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ExtensionApiTest::SetUpCommandLine(command_line);
     // Make ARC enabled for ArcAvailable/ArcEnabled tests.
     arc::SetArcAvailableCommandLineForTesting(command_line);
   }
@@ skipping 38 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ChromeOSManagedDeviceInfoPrivateTest);
 };
 
 IN_PROC_BROWSER_TEST_F(ChromeOSManagedDeviceInfoPrivateTest, Managed) {
   ASSERT_TRUE(
       RunPlatformAppTestWithArg("chromeos_info_private/extended", "managed"))
       << message_;
 }