Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4356)

Unified Diff: chrome/browser/chromeos/extensions/info_private_apitest.cc

Issue 2761263007: ChromeOS: Expose 'device type' signal (Closed)
Patch Set: replace StringPrintf with string Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/info_private_apitest.cc
diff --git a/chrome/browser/chromeos/extensions/info_private_apitest.cc b/chrome/browser/chromeos/extensions/info_private_apitest.cc
index 0296446b949bd587e7886f96d41aff5fc98609c6..bf8f716866cfe66b42962381683e8d8bb244af4e 100644
--- a/chrome/browser/chromeos/extensions/info_private_apitest.cc
+++ b/chrome/browser/chromeos/extensions/info_private_apitest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/sys_info.h"
#include "base/values.h"
#include "chrome/browser/chromeos/arc/arc_util.h"
#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
@@ -32,6 +33,12 @@ class ChromeOSInfoPrivateTest : public ExtensionApiTest {
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kAppId,
kTestAppId);
}
+
+ void SetDeviceType(const std::string& device_type) {
+ const std::string lsb_release = std::string("DEVICETYPE=") + device_type;
+ base::SysInfo::SetChromeOSVersionInfoForTest(lsb_release,
+ base::Time::Now());
+ }
};
IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, TestGetAndSet) {
@@ -82,6 +89,40 @@ IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, ArcNotAvailable) {
<< message_;
}
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebase) {
+ SetDeviceType("CHROMEBASE");
+ ASSERT_TRUE(
+ RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebase"))
+ << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebit) {
+ SetDeviceType("CHROMEBIT");
+ ASSERT_TRUE(
+ RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebit"))
+ << message_;
+}
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebook) {
+ SetDeviceType("CHROMEBOOK");
+ ASSERT_TRUE(
+ RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebook"))
+ << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, Chromebox) {
+ SetDeviceType("CHROMEBOX");
+ ASSERT_TRUE(
+ RunPlatformAppTestWithArg("chromeos_info_private/extended", "chromebox"))
+ << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeOSInfoPrivateTest, UnknownDeviceType) {
+ SetDeviceType("UNKNOWN");
+ ASSERT_TRUE(RunPlatformAppTestWithArg("chromeos_info_private/extended",
+ "unknown device type"))
+ << message_;
+}
+
class ChromeOSArcInfoPrivateTest : public ChromeOSInfoPrivateTest {
public:
ChromeOSArcInfoPrivateTest() = default;
« no previous file with comments | « chrome/browser/chromeos/extensions/info_private_api.cc ('k') | chrome/common/extensions/api/chromeos_info_private.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698