Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official

Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official

The issue was:
* chrome_test_util::SetWWANStateTo() calls -connectionTypeChanged: on
the metrics mediator.
* -connectionTypeChanged: should only be called when the mediator cares
about WWAN status (DCHECK in the method).
* The metrics mediator doesn't care about WWAN status when not recording
or not on wifi-only ([self setWatchWWANEnabled:(optIn && wifiOnly)],
which turns off listening to connection type changes).

To fix it, I remove the calls to change the WWAN status within the test,
as it calls -connectionTypeChanged:, which is not expected on the
mediator in that configuration.

BUG=700839
R=liaoyuke@chromium.org,olivierrobin@chromium.org

Review-Url: https://codereview.chromium.org/2762623004
Cr-Commit-Position: refs/heads/master@{#458705}
Committed: https://chromium.googlesource.com/chromium/src/+/0e1ab062c1452c0baa9c9adf3ad9671c268e06fe

[lpromero, 2017-03-20 16:55:46]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 16:56:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-03-20 16:56:09]

lpromero@chromium.org changed reviewers:
+ marq@chromium.org

[lpromero, 2017-03-20 16:56:09]

marq@chromium.org: Please review changes in metrics_mediator.

[lpromero, 2017-03-20 16:56:56]

https://codereview.chromium.org/2762623004/diff/1/ios/chrome/browser/ui/setti...
File ios/chrome/browser/ui/settings/settings_egtest.mm (left):

https://codereview.chromium.org/2762623004/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/settings_egtest.mm:612: [self
assertMetricsServiceDisabled:serviceType];
Note that this was a typo already, as it should have been
-assertMetricsServiceEnabled:.

[lpromero, 2017-03-20 17:07:57]

The CQ bit was unchecked by lpromero@chromium.org

[liaoyuke, 2017-03-21 05:35:34]

lgtm on eg test file. Thank you for fixing this!

[marq (ping after 24h), 2017-03-21 08:38:45]

lgtm

[lpromero, 2017-03-22 10:01:00]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-22 10:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
liaoyuke@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2762623004/#ps20001
(title: "Don't add DCHECK")

[commit-bot: I haz the power, 2017-03-22 10:01:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 10:11:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490176860098760,
"parent_rev": "934a474195968e5902c274a11df883723c718513", "commit_rev":
"0e1ab062c1452c0baa9c9adf3ad9671c268e06fe"}

[commit-bot: I haz the power, 2017-03-22 10:12:19]

Description was changed from

==========
Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official

The issue was:
* chrome_test_util::SetWWANStateTo() calls -connectionTypeChanged: on
the metrics mediator.
* -connectionTypeChanged: should only be called when the mediator cares
about WWAN status (DCHECK in the method).
* The metrics mediator doesn't care about WWAN status when not recording
or not on wifi-only ([self setWatchWWANEnabled:(optIn && wifiOnly)],
which turns off listening to connection type changes).

To fix it, I remove the calls to change the WWAN status within the test,
as it calls -connectionTypeChanged:, which is not expected on the
mediator in that configuration.

BUG=700839
R=liaoyuke@chromium.org,olivierrobin@chromium.org
==========

to

==========
Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official

The issue was:
* chrome_test_util::SetWWANStateTo() calls -connectionTypeChanged: on
the metrics mediator.
* -connectionTypeChanged: should only be called when the mediator cares
about WWAN status (DCHECK in the method).
* The metrics mediator doesn't care about WWAN status when not recording
or not on wifi-only ([self setWatchWWANEnabled:(optIn && wifiOnly)],
which turns off listening to connection type changes).

To fix it, I remove the calls to change the WWAN status within the test,
as it calls -connectionTypeChanged:, which is not expected on the
mediator in that configuration.

BUG=700839
R=liaoyuke@chromium.org,olivierrobin@chromium.org

Review-Url: https://codereview.chromium.org/2762623004
Cr-Commit-Position: refs/heads/master@{#458705}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e1ab062c1452c0baa9c9adf3ad9...
==========

[commit-bot: I haz the power, 2017-03-22 10:12:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e1ab062c1452c0baa9c9adf3ad9...