Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2760463002: Add more logging when fetching layout test results. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more logging when fetching layout test results. This changes logging in rebaseline_cl.py_and adds logging in buildbot.py. Reason: Recently rebaseline-cl said it couldn't fetch results when it appeared that results were actually archived. If this happens again, a better log output would be helpful. BUG=701963 Review-Url: https://codereview.chromium.org/2760463002 Cr-Commit-Position: refs/heads/master@{#457589} Committed: https://chromium.googlesource.com/chromium/src/+/5c28e1999704819f1c19950bca846c982d7d8c76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py View 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py View 2 chunks +28 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 9 months ago (2017-03-16 21:19:12 UTC) #2
jeffcarp
lgtm
3 years, 9 months ago (2017-03-16 21:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760463002/1
3 years, 9 months ago (2017-03-16 21:46:04 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 22:46:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c28e1999704819f1c19950bca84...

Powered by Google App Engine
This is Rietveld 408576698