third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py - Issue 2760463002: Add more logging when fetching layout test results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2760463002: Add more logging when fetching layout test results. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

index 9141a8ee80d6094d6dd69e67b34815d4b7451037..2c4eed4ea8b9739ab0411a16e330768217ff6546 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

@@ -154,11 +154,9 @@ class RebaselineCL(AbstractParallelRebaselineCommand):

results_url = buildbot.results_url(build.builder_name, build.build_number)

layout_test_results = buildbot.fetch_results(build)

if layout_test_results is None:

- _log.error(

- 'Failed to fetch results from "%s".\n'

- 'Try starting a new job for %s by running :\n'

- ' git cl try -b %s',

- results_url, build.builder_name, build.builder_name)

+ _log.error('Failed to fetch results for: %s', build)

+ _log.error('Results were expected to exist at:\n%s/results.html', results_url)

+ _log.error('If the job failed, you could retry by running:\ngit cl try -b %s', build.builder_name)

return None

results[build] = layout_test_results

return results