Add more logging when fetching layout test results.

third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py

 # Copyright (C) 2009 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #    * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #    * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 11 matching lines @@
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import unittest
 
 from webkitpy.common.net.buildbot import BuildBot, Build, filter_latest_builds
+from webkitpy.common.system.log_testing import LoggingTestCase
 
 
-class BuilderTest(unittest.TestCase):
+class BuilderTest(LoggingTestCase):
 
     def test_results_url_no_build_number(self):
         self.assertEqual(
             BuildBot().results_url('Test Builder'),
             'https://storage.googleapis.com/chromium-layout-test-archives/Test_Builder/results/layout-test-results')
 
     def test_results_url_with_build_number(self):
         self.assertEqual(
             BuildBot().results_url('Test Builder', 10),
             'https://storage.googleapis.com/chromium-layout-test-archives/Test_Builder/10/layout-test-results')
 
     def test_builder_results_url_base(self):
         self.assertEqual(
             BuildBot().builder_results_url_base('WebKit Mac10.8 (dbg)'),
             'https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_8__dbg_')
 
     def test_accumulated_results_url(self):
         self.assertEqual(
             BuildBot().accumulated_results_url_base('WebKit Mac10.8 (dbg)'),
             'https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_8__dbg_/results/layout-test-results')
 
-    def fetch_layout_test_results_with_no_responses(self):
+    def test_fetch_layout_test_results_with_no_results_fetched(self):
         buildbot = BuildBot()
-        buildbot._fetch_file = lambda: None  # pylint: disable=protected-access
-        self.assertIsNone(buildbot.fetch_layout_test_results(buildbot.results_url('Builder')))
+
+        def fetch_file(_, filename):
+            return None if filename == 'failing_results.json' else 'contents'
+
+        buildbot.fetch_file = fetch_file
+        results = buildbot.fetch_layout_test_results(buildbot.results_url('B'))
+        self.assertIsNone(results)
+        self.assertLog([
+            'WARNING: Got 404 response from:\n'
+            'https://storage.googleapis.com/chromium-layout-test-archives/B/results/layout-test-results/failing_results.json\n'
+        ])
+
+    def test_fetch_layout_test_results_with_no_last_change_file(self):
+        buildbot = BuildBot()
+
+        def fetch_file(_, filename):
+            return None if filename == 'LAST_CHANGE' else 'contents'
+
+        buildbot.fetch_file = fetch_file
+        results = buildbot.fetch_layout_test_results(buildbot.results_url('B'))
+        self.assertIsNone(results)
+        self.assertLog([
+            'WARNING: Got 404 response from:\n'
+            'https://storage.googleapis.com/chromium-layout-test-archives/B/results/layout-test-results/LAST_CHANGE\n'
+        ])
 
 
 class BuildBotHelperFunctionTest(unittest.TestCase):
 
     def test_filter_latest_jobs_empty(self):
         self.assertEqual(filter_latest_builds([]), [])
 
     def test_filter_latest_jobs_higher_build_first(self):
         self.assertEqual(
             filter_latest_builds([Build('foo', 5), Build('foo', 3), Build('bar', 5)]),
             [Build('bar', 5), Build('foo', 5)])
 
     def test_filter_latest_jobs_higher_build_last(self):
         self.assertEqual(
             filter_latest_builds([Build('foo', 3), Build('bar', 5), Build('foo', 5)]),
             [Build('bar', 5), Build('foo', 5)])
 
     def test_filter_latest_jobs_no_build_number(self):
         self.assertEqual(
             filter_latest_builds([Build('foo', 3), Build('bar'), Build('bar')]),
             [Build('bar'), Build('foo', 3)])