Migrate WTF::HashMap::remove() to ::erase()

Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2759703002
Cr-Commit-Position: refs/heads/master@{#458444}
Committed: https://chromium.googlesource.com/chromium/src/+/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9

[pilgrim_google, 2017-03-17 16:15:51]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-03-17 16:16:03]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-03-17 16:16:17]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:16:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 17:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:12:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2017-03-17 17:48:26]

LGTM

[Yuta Kitamura, 2017-03-21 01:50:06]

lgtm

[pilgrim_google, 2017-03-21 14:10:57]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-03-21 14:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2759703002/#ps20001
(title: "rebase, fix one platform-specific reference")

[commit-bot: I haz the power, 2017-03-21 14:11:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 14:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:19:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2017-03-21 14:26:43]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

[pilgrim_google, 2017-03-21 14:26:43]

pilgrim@chromium.org changed reviewers:
+ sky@chromium.org

[pilgrim_google, 2017-03-21 14:26:46]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:27:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:04:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490106406049710,
"parent_rev": "f23d7fd62a4239f5cd2498129b4aeadac32984c3", "commit_rev":
"aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9"}

[commit-bot: I haz the power, 2017-03-21 17:05:58]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2759703002
Cr-Commit-Position: refs/heads/master@{#458444}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa4954b93c5c4a8e1924e31e6754...
==========

[commit-bot: I haz the power, 2017-03-21 17:06:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aa4954b93c5c4a8e1924e31e6754...