third_party/WebKit/Source/core/dom/SelectorQuery.cpp - Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase() (Closed)

Patch Set: rebase, fix one platform-specific reference Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

diff --git a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

index a43f8a6d427c2d7234d8799baf7ff599e1d4c34c..3ea4dee132f67aefccbc5ec78b714911370e1135 100644

--- a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

+++ b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

@@ -636,7 +636,7 @@ SelectorQuery* SelectorQueryCache::add(const AtomicString& selectors,

const unsigned maximumSelectorQueryCacheSize = 256;

if (m_entries.size() == maximumSelectorQueryCacheSize)

- m_entries.remove(m_entries.begin());

+ m_entries.erase(m_entries.begin());

return m_entries

.insert(selectors, SelectorQuery::adopt(std::move(selectorList)))