third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp - Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

Issue 2759703002: Migrate WTF::HashMap::remove() to ::erase() (Closed)

Patch Set: rebase, fix one platform-specific reference Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/FormController.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

index 2699ecfb041939ee685ec4f0c09b6d9e9546cf77..73dc097422dd661508b4e3b0c36249a6d26c8fb9 100644

--- a/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

@@ -151,7 +151,7 @@ void RadioButtonGroup::remove(HTMLInputElement* button) {

bool wasValid = isValid();

DCHECK_EQ(it->value, button->isRequired());

updateRequiredButton(*it, false);

- m_members.remove(it);

+ m_members.erase(it);

if (m_checkedButton == button)

m_checkedButton = nullptr;