Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2759613003: Use SameDocument instead of SamePage term on iOS. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument instead of SamePage term on iOS. BUG=695189 Review-Url: https://codereview.chromium.org/2759613003 Cr-Commit-Position: refs/heads/master@{#458531} Committed: https://chromium.googlesource.com/chromium/src/+/12977a2e65c4dd71808494a55ac291c94febacd9

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Fixed test #

Patch Set 4 : Actually fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M ios/chrome/browser/web/window_open_by_dom_egtest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/testing/data/http_server_files/window_open.html View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 4 chunks +6 lines, -6 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/navigation_context_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/navigation_context_impl_unittest.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-21 17:30:38 UTC) #11
kkhorimoto
Thanks for working to push my "same document" naming suggestion to all platforms :) lgtm ...
3 years, 9 months ago (2017-03-21 17:52:47 UTC) #15
Eugene But (OOO till 7-30)
Thanks for quick review! Tests failure seems unrelated, so I just rerunning the bot to ...
3 years, 9 months ago (2017-03-21 17:58:10 UTC) #16
baxley
On 2017/03/21 17:58:10, Eugene But wrote: > Thanks for quick review! Tests failure seems unrelated, ...
3 years, 9 months ago (2017-03-21 18:04:53 UTC) #17
Eugene But (OOO till 7-30)
On 2017/03/21 18:04:53, baxley wrote: > On 2017/03/21 17:58:10, Eugene But wrote: > > Thanks ...
3 years, 9 months ago (2017-03-21 20:15:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759613003/60001
3 years, 9 months ago (2017-03-21 20:16:09 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 20:24:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/12977a2e65c4dd71808494a55ac2...

Powered by Google App Engine
This is Rietveld 408576698