Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: ios/web/web_state/web_state_impl.mm

Issue 2759613003: Use SameDocument instead of SamePage term on iOS. (Closed)
Patch Set: Actually fixed tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/web_state/web_state_impl.h" 5 #import "ios/web/web_state/web_state_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 facade_delegate_ = facade_delegate; 180 facade_delegate_ = facade_delegate;
181 } 181 }
182 182
183 void WebStateImpl::OnNavigationCommitted(const GURL& url) { 183 void WebStateImpl::OnNavigationCommitted(const GURL& url) {
184 std::unique_ptr<NavigationContext> context = 184 std::unique_ptr<NavigationContext> context =
185 NavigationContextImpl::CreateNavigationContext(this, url); 185 NavigationContextImpl::CreateNavigationContext(this, url);
186 for (auto& observer : observers_) 186 for (auto& observer : observers_)
187 observer.DidFinishNavigation(context.get()); 187 observer.DidFinishNavigation(context.get());
188 } 188 }
189 189
190 void WebStateImpl::OnSamePageNavigation(const GURL& url) { 190 void WebStateImpl::OnSameDocumentNavigation(const GURL& url) {
191 std::unique_ptr<NavigationContext> context = 191 std::unique_ptr<NavigationContext> context =
192 NavigationContextImpl::CreateSamePageNavigationContext(this, url); 192 NavigationContextImpl::CreateSameDocumentNavigationContext(this, url);
193 for (auto& observer : observers_) 193 for (auto& observer : observers_)
194 observer.DidFinishNavigation(context.get()); 194 observer.DidFinishNavigation(context.get());
195 } 195 }
196 196
197 void WebStateImpl::OnErrorPageNavigation(const GURL& url) { 197 void WebStateImpl::OnErrorPageNavigation(const GURL& url) {
198 std::unique_ptr<NavigationContext> context = 198 std::unique_ptr<NavigationContext> context =
199 NavigationContextImpl::CreateErrorPageNavigationContext(this, url); 199 NavigationContextImpl::CreateErrorPageNavigationContext(this, url);
200 for (auto& observer : observers_) 200 for (auto& observer : observers_)
201 observer.DidFinishNavigation(context.get()); 201 observer.DidFinishNavigation(context.get());
202 } 202 }
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 const LoadCommittedDetails& load_details) { 761 const LoadCommittedDetails& load_details) {
762 for (auto& observer : observers_) 762 for (auto& observer : observers_)
763 observer.NavigationItemCommitted(load_details); 763 observer.NavigationItemCommitted(load_details);
764 } 764 }
765 765
766 WebState* WebStateImpl::GetWebState() { 766 WebState* WebStateImpl::GetWebState() {
767 return this; 767 return this;
768 } 768 }
769 769
770 } // namespace web 770 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698