ios/chrome/browser/web/window_open_by_dom_egtest.mm - Issue 2759613003: Use SameDocument instead of SamePage term on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/window_open_by_dom_egtest.mm

Issue 2759613003: Use SameDocument instead of SamePage term on iOS. (Closed)

Patch Set: Actually fixed tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/window_open_by_dom_egtest.mm

diff --git a/ios/chrome/browser/web/window_open_by_dom_egtest.mm b/ios/chrome/browser/web/window_open_by_dom_egtest.mm

index 8e20f54e8512e4b8af40f1ffe463f1ed958f97b4..7938f833132bd52b361dd648fe7d0d668e582be0 100644

--- a/ios/chrome/browser/web/window_open_by_dom_egtest.mm

+++ b/ios/chrome/browser/web/window_open_by_dom_egtest.mm

@@ -69,7 +69,7 @@ const char kTestURL[] =

ExecuteJavaScript(@"sessionStorage.setItem('key', 'value');", &error);

GREYAssert(!error, @"Error during script execution: %@", error);

- TapWebViewElementWithId("webScenarioWindowOpenSamePageWithBlankTarget");

+ TapWebViewElementWithId("webScenarioWindowOpenSameURLWithBlankTarget");

AssertMainTabCount(2);

[[EarlGrey selectElementWithMatcher:WebViewContainingText("Expected result")]

assertWithMatcher:grey_notNil()];

« no previous file with comments | « no previous file | ios/testing/data/http_server_files/window_open.html » ('j') | no next file with comments »