Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2759473002: [WebViewShell] Clean-up lint warnings in android_webview/tools/system_webview_shell/apk/ (Closed)

Created:
3 years, 9 months ago by timvolodine
Modified:
3 years, 9 months ago
Reviewers:
Torne, Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebViewShell] Clean-up lint warnings in android_webview/tools/system_webview_shell/apk/ Suppress and document lint warnings due to api level deprecations. The supressions are added because the SystemWebViewShell supports api level 19 and up, while the deprecations happened at higher level. In particular the following methods are involved: - shouldOverrideUrlLoading() - setGeolocationDatabasePath() BUG=702286 Review-Url: https://codereview.chromium.org/2759473002 Cr-Commit-Position: refs/heads/master@{#458050} Committed: https://chromium.googlesource.com/chromium/src/+/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
timvolodine
3 years, 9 months ago (2017-03-16 18:05:45 UTC) #4
timvolodine
+tobiasjs@: could you take a look? if you have the time, since torne@ is OOO
3 years, 9 months ago (2017-03-17 15:27:34 UTC) #8
Torne
lgtm
3 years, 9 months ago (2017-03-20 11:46:35 UTC) #9
timvolodine
On 2017/03/20 11:46:35, Torne wrote: > lgtm thanks!
3 years, 9 months ago (2017-03-20 13:21:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759473002/1
3 years, 9 months ago (2017-03-20 13:22:08 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 13:32:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bebdf5033d1104e9ae902ef7a6fd...

Powered by Google App Engine
This is Rietveld 408576698