Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java

Issue 2759473002: [WebViewShell] Clean-up lint warnings in android_webview/tools/system_webview_shell/apk/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
diff --git a/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java b/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
index f23ec7544501a3c16f5fbc702433861cb633bc36..224b5aa0f66aa2a23a7f084cba879b604fc88b7f 100644
--- a/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
+++ b/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
@@ -269,6 +269,7 @@ public class WebViewBrowserActivity extends Activity implements PopupMenu.OnMenu
setUrlBarText(url);
}
+ @SuppressWarnings("deprecation") // because we support api level 19 and up.
@Override
public boolean shouldOverrideUrlLoading(WebView webView, String url) {
// "about:" and "chrome:" schemes are internal to Chromium;
@@ -460,6 +461,9 @@ public class WebViewBrowserActivity extends Activity implements PopupMenu.OnMenu
}
}
+ // setGeolocationDatabasePath deprecated in api level 24,
+ // but we still use it because we support api level 19 and up.
+ @SuppressWarnings("deprecation")
private void initializeSettings(WebSettings settings) {
settings.setJavaScriptEnabled(true);

Powered by Google App Engine
This is Rietveld 408576698