Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2982)

Unified Diff: android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java

Issue 2759473002: [WebViewShell] Clean-up lint warnings in android_webview/tools/system_webview_shell/apk/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java
diff --git a/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java b/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java
index d6eb5c999654c2e6b6bfeb17b1577fa85864ffa0..a29e525e702affa04cf5c55069aecd8cb0af906d 100644
--- a/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java
+++ b/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java
@@ -53,17 +53,18 @@ public class TelemetryActivity extends Activity {
}
webView.setWebViewClient(new WebViewClient() {
- @Override
- public boolean shouldOverrideUrlLoading(WebView view, String url) {
- return false;
- }
+ @SuppressWarnings("deprecation") // because we support api level 19 and up.
+ @Override
+ public boolean shouldOverrideUrlLoading(WebView view, String url) {
+ return false;
+ }
- @Override
- public void onPageFinished(WebView view, String url) {
- super.onPageFinished(view, url);
- Trace.endSection();
- Trace.endSection();
- }
+ @Override
+ public void onPageFinished(WebView view, String url) {
+ super.onPageFinished(view, url);
+ Trace.endSection();
+ Trace.endSection();
+ }
});
Trace.beginSection(loadUrlTraceTag == null ? DEFAULT_LOAD_URL_TRACE_TAG : loadUrlTraceTag);

Powered by Google App Engine
This is Rietveld 408576698