Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2758243002: Reland of Disable VEA usage in MediaRecorder until flaky test is addressed (Closed)

Created:
3 years, 9 months ago by Henrik Grunell
Modified:
3 years, 9 months ago
Reviewers:
emircan, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable VEA usage in MediaRecorder until flaky test is addressed (patchset #1 id:1 of https://codereview.chromium.org/2754473008/ ) Reason for revert: Still flaky after the revert. Re-disabling. Original issue's description: > Revert of Disable VEA usage in MediaRecorder until flaky test is addressed (patchset #2 id:20001 of https://codereview.chromium.org/2727633008/ ) > > Reason for revert: > I believe this has the same underlying issue as https://bugs.chromium.org/p/chromium/issues/detail?id=701030, which is fixed. I will re-enable the tests to see the effects. > > Original issue's description: > > Disable VEA usage in MediaRecorder until flaky test is addressed > > > > BUG=698441 > > > > Review-Url: https://codereview.chromium.org/2727633008 > > Cr-Commit-Position: refs/heads/master@{#454759} > > Committed: https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea55566873a99bb20 > > TBR=mcasas@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=698441 > > Review-Url: https://codereview.chromium.org/2754473008 > Cr-Commit-Position: refs/heads/master@{#457622} > Committed: https://chromium.googlesource.com/chromium/src/+/8086b9ac7fe4598925a84e6169760187022c3eb3 TBR=mcasas@chromium.org,emircan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698441 Review-Url: https://codereview.chromium.org/2758243002 Cr-Commit-Position: refs/heads/master@{#458035} Committed: https://chromium.googlesource.com/chromium/src/+/b0782aed1dbfcbc1258d33961f961cfb81b20c45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/renderer/media_recorder/video_track_recorder.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Henrik Grunell
Created Reland of Disable VEA usage in MediaRecorder until flaky test is addressed
3 years, 9 months ago (2017-03-20 08:47:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758243002/1
3 years, 9 months ago (2017-03-20 08:47:34 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 10:34:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0782aed1dbfcbc1258d33961f96...

Powered by Google App Engine
This is Rietveld 408576698