Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2754473008: Revert of Disable VEA usage in MediaRecorder until flaky test is addressed (Closed)

Created:
3 years, 9 months ago by emircan
Modified:
3 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable VEA usage in MediaRecorder until flaky test is addressed (patchset #2 id:20001 of https://codereview.chromium.org/2727633008/ ) Reason for revert: I believe this has the same underlying issue as https://bugs.chromium.org/p/chromium/issues/detail?id=701030, which is fixed. I will re-enable the tests to see the effects. Original issue's description: > Disable VEA usage in MediaRecorder until flaky test is addressed > > BUG=698441 > > Review-Url: https://codereview.chromium.org/2727633008 > Cr-Commit-Position: refs/heads/master@{#454759} > Committed: https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea55566873a99bb20 TBR=mcasas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698441 Review-Url: https://codereview.chromium.org/2754473008 Cr-Commit-Position: refs/heads/master@{#457622} Committed: https://chromium.googlesource.com/chromium/src/+/8086b9ac7fe4598925a84e6169760187022c3eb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/renderer/media_recorder/video_track_recorder.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
emircan
Created Revert of Disable VEA usage in MediaRecorder until flaky test is addressed
3 years, 9 months ago (2017-03-16 23:17:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754473008/1
3 years, 9 months ago (2017-03-16 23:18:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8086b9ac7fe4598925a84e6169760187022c3eb3
3 years, 9 months ago (2017-03-17 00:23:48 UTC) #6
Henrik Grunell
3 years, 9 months ago (2017-03-20 08:47:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2758243002/ by grunell@chromium.org.

The reason for reverting is: Still flaky after the revert. Re-disabling..

Powered by Google App Engine
This is Rietveld 408576698