Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2727633008: Disable VEA usage in MediaRecorder until flaky test is addressed (Closed)

Created:
3 years, 9 months ago by emircan
Modified:
3 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable VEA usage in MediaRecorder until flaky test is addressed BUG=698441 Review-Url: https://codereview.chromium.org/2727633008 Cr-Commit-Position: refs/heads/master@{#454759} Committed: https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea55566873a99bb20

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/renderer/media_recorder/video_track_recorder.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
emircan
See the bug for more info. There hasn't been any changes in MF VEA last ...
3 years, 9 months ago (2017-03-04 01:51:53 UTC) #4
mcasas
lgtm
3 years, 9 months ago (2017-03-04 02:00:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727633008/1
3 years, 9 months ago (2017-03-04 02:00:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/164751) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-04 02:02:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727633008/20001
3 years, 9 months ago (2017-03-04 04:08:40 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea55566873a99bb20
3 years, 9 months ago (2017-03-04 04:18:28 UTC) #20
emircan
3 years, 9 months ago (2017-03-16 23:17:43 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2754473008/ by emircan@chromium.org.

The reason for reverting is: I believe this has the same underlying issue as
https://bugs.chromium.org/p/chromium/issues/detail?id=701030, which is fixed. I
will re-enable the tests to see the effects..

Powered by Google App Engine
This is Rietveld 408576698