|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by emircan Modified:
3 years, 9 months ago Reviewers:
mcasas CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable VEA usage in MediaRecorder until flaky test is addressed
BUG=698441
Review-Url: https://codereview.chromium.org/2727633008
Cr-Commit-Position: refs/heads/master@{#454759}
Committed: https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea55566873a99bb20
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Description was changed from ========== disable flaky time. BUG= ========== to ========== Disable VEA usage in MediaRecorder until flaky test is addressed BUG=698441 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
See the bug for more info. There hasn't been any changes in MF VEA last week but this test started failing. It might point to a real issue in Win 8, so I will disable VEA usage for Win 8 until finding out the underlying reason. Let me know if you prefer me to just disable the test instead.
The CQ bit was checked by mcasas@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2727633008/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488600514352350,
"parent_rev": "ae6a7f59844e81eddd4ef1b87ca9a95ee1b270f9", "commit_rev":
"4353139d449d0d76814308e81e4715befc513ada"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488600514352350,
"parent_rev": "78ea87a165973258b0176d91d5f8721ad074beb1", "commit_rev":
"26c6a0e07e73b1e9d357edcea55566873a99bb20"}
Message was sent while issue was closed.
Description was changed from ========== Disable VEA usage in MediaRecorder until flaky test is addressed BUG=698441 ========== to ========== Disable VEA usage in MediaRecorder until flaky test is addressed BUG=698441 Review-Url: https://codereview.chromium.org/2727633008 Cr-Commit-Position: refs/heads/master@{#454759} Committed: https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea555... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/26c6a0e07e73b1e9d357edcea555...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2754473008/ by emircan@chromium.org. The reason for reverting is: I believe this has the same underlying issue as https://bugs.chromium.org/p/chromium/issues/detail?id=701030, which is fixed. I will re-enable the tests to see the effects.. |
