Android: Add APK patch size estimates to resource_sizes.py.

Android: Add APK patch size estimates to resource_sizes.py.

APK patch size estimates will be used on certain perf builders, and will
track estimated patch size based on a reference APK (built by the same
builder) for the current milestone.

BUG=695188
Review-Url: https://codereview.chromium.org/2757293002
Cr-Commit-Position: refs/heads/master@{#458181}
Committed: https://chromium.googlesource.com/chromium/src/+/d5240cc0a6bd41103e36d53cd56de9994bec89d4

[estevenson, 2017-03-20 16:55:25]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-03-20 16:55:25]

ptal Andrew!

[agrieve, 2017-03-20 17:53:40]

Exciting stuff!

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
build/android/resource_sizes.py:54: import apk_patch_size_estimator  as
patch_size # pylint: disable=import-error
nit: you have a double space in here, although even better would be to not alias
it (I believe style guide discourages this)

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
build/android/resource_sizes.py:746: argparser.add_argument('--bucket',
default=apk_downloader.DEFAULT_BUCKET,
name bikeshed: how about --reference-apk-bucket and --reference-apk-builder

[agrieve, 2017-03-20 17:53:50]

On 2017/03/20 17:53:40, agrieve wrote:
> Exciting stuff!
> 
>
https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
> File build/android/resource_sizes.py (right):
> 
>
https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
> build/android/resource_sizes.py:54: import apk_patch_size_estimator  as
> patch_size # pylint: disable=import-error
> nit: you have a double space in here, although even better would be to not
alias
> it (I believe style guide discourages this)
> 
>
https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
> build/android/resource_sizes.py:746: argparser.add_argument('--bucket',
> default=apk_downloader.DEFAULT_BUCKET,
> name bikeshed: how about --reference-apk-bucket and --reference-apk-builder

lgtm

[estevenson, 2017-03-20 18:02:37]

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
build/android/resource_sizes.py:54: import apk_patch_size_estimator  as
patch_size # pylint: disable=import-error
On 2017/03/20 17:53:40, agrieve wrote:
> nit: you have a double space in here, although even better would be to not
alias
> it (I believe style guide discourages this)

Done.

https://codereview.chromium.org/2757293002/diff/40001/build/android/resource_...
build/android/resource_sizes.py:746: argparser.add_argument('--bucket',
default=apk_downloader.DEFAULT_BUCKET,
On 2017/03/20 17:53:40, agrieve wrote:
> name bikeshed: how about --reference-apk-bucket and --reference-apk-builder

Done.

[estevenson, 2017-03-20 19:51:21]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-03-20 19:51:22]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2757293002/#ps60001
(title: "Fix import & make args descriptive")

[commit-bot: I haz the power, 2017-03-20 19:52:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:07:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490039481658800,
"parent_rev": "d1cb28855c8d2d3413fda1655bd71bf7e7cc16b3", "commit_rev":
"d5240cc0a6bd41103e36d53cd56de9994bec89d4"}

[commit-bot: I haz the power, 2017-03-20 21:08:01]

Description was changed from

==========
Android: Add APK patch size estimates to resource_sizes.py.

APK patch size estimates will be used on certain perf builders, and will
track estimated patch size based on a reference APK (built by the same
builder) for the current milestone.

BUG=695188
==========

to

==========
Android: Add APK patch size estimates to resource_sizes.py.

APK patch size estimates will be used on certain perf builders, and will
track estimated patch size based on a reference APK (built by the same
builder) for the current milestone.

BUG=695188

Review-Url: https://codereview.chromium.org/2757293002
Cr-Commit-Position: refs/heads/master@{#458181}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5240cc0a6bd41103e36d53cd56d...
==========

[commit-bot: I haz the power, 2017-03-20 21:08:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d5240cc0a6bd41103e36d53cd56d...

[estevenson, 2017-03-21 14:26:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2764923002/ by estevenson@chromium.org.

The reason for reverting is: Didn't update arg names properly..