Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2764923002: Revert of Android: Add APK patch size estimates to resource_sizes.py. (Closed)

Created:
3 years, 9 months ago by estevenson
Modified:
3 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Add APK patch size estimates to resource_sizes.py. (patchset #4 id:60001 of https://codereview.chromium.org/2757293002/ ) Reason for revert: Didn't update arg names properly. Original issue's description: > Android: Add APK patch size estimates to resource_sizes.py. > > APK patch size estimates will be used on certain perf builders, and will > track estimated patch size based on a reference APK (built by the same > builder) for the current milestone. > > BUG=695188 > > Review-Url: https://codereview.chromium.org/2757293002 > Cr-Commit-Position: refs/heads/master@{#458181} > Committed: https://chromium.googlesource.com/chromium/src/+/d5240cc0a6bd41103e36d53cd56de9994bec89d4 TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695188 Review-Url: https://codereview.chromium.org/2764923002 Cr-Commit-Position: refs/heads/master@{#458403} Committed: https://chromium.googlesource.com/chromium/src/+/9a2f897d567a9cf89932703ee62982b3bc63400d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -149 lines) Patch
D build/android/binary_size/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D build/android/binary_size/apk_downloader.py View 1 chunk +0 lines, -75 lines 0 comments Download
D build/android/binary_size/apks/README.md View 1 chunk +0 lines, -24 lines 0 comments Download
A build/android/binary_size/update_apks.py View 1 chunk +71 lines, -0 lines 0 comments Download
M build/android/resource_sizes.py View 6 chunks +0 lines, -40 lines 0 comments Download
M third_party/apk-patch-size-estimator/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/apk-patch-size-estimator/apk_patch_size_estimator.py View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
estevenson
Created Revert of Android: Add APK patch size estimates to resource_sizes.py.
3 years, 9 months ago (2017-03-21 14:26:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764923002/1
3 years, 9 months ago (2017-03-21 14:27:26 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 14:30:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a2f897d567a9cf89932703ee629...

Powered by Google App Engine
This is Rietveld 408576698