Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/apk-patch-size-estimator/apk_patch_size_estimator.py

Issue 2757293002: Android: Add APK patch size estimates to resource_sizes.py. (Closed)
Patch Set: Fix import & make args descriptive Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/apk-patch-size-estimator/README.chromium ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/apk-patch-size-estimator/apk_patch_size_estimator.py
diff --git a/third_party/apk-patch-size-estimator/apk_patch_size_estimator.py b/third_party/apk-patch-size-estimator/apk_patch_size_estimator.py
index 1be08e731a2e1610e60058c9d4ac037568bfe73c..64b4bb635b6a355d1d249a99048a0fed024d8cd8 100755
--- a/third_party/apk-patch-size-estimator/apk_patch_size_estimator.py
+++ b/third_party/apk-patch-size-estimator/apk_patch_size_estimator.py
@@ -36,6 +36,9 @@ import math
import os
import subprocess
+_FILEBYFILE_JAR_PATH = os.path.abspath(
+ os.path.join(os.path.dirname(__file__), 'lib', 'file-by-file-tools.jar'))
+
bsdiff_path = None
gzip_path = None
head_path = None
@@ -259,8 +262,8 @@ def calculate_filebyfile(old_file, new_file, save_patch_path, temp_path):
# We use a jar from https://github.com/andrewhayden/archive-patcher
if os.path.exists(filebyfile_patch_path): os.remove(filebyfile_patch_path)
p = subprocess.Popen(
- [java_path, '-jar', 'lib/file-by-file-tools.jar', '--generate',
- '--old', old_file, '--new', new_file, '--patch', filebyfile_patch_path],
+ [java_path, '-jar', _FILEBYFILE_JAR_PATH, '--generate', '--old', old_file,
+ '--new', new_file, '--patch', filebyfile_patch_path],
shell=False)
ret_code = p.wait()
if ret_code != 0: raise Exception(
« no previous file with comments | « third_party/apk-patch-size-estimator/README.chromium ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698