Fix assert failure in AnimatableStrokeDasharrayList::equalTo()

Fix assert failure in AnimatableStrokeDasharrayList::equalTo()

Inherited methods were asserting AnimatableStrokeDasharrayList objects
were the parent class AnimatableValue type. Changed type check to allow
the subclass when up casting.
Added unittest case to test fix.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160064

[alancutter (OOO until 2018), 2013-10-18 00:11:46]

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
File Source/core/animation/AnimatableStrokeDasharrayListTest.cpp (right):

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
Source/core/animation/AnimatableStrokeDasharrayListTest.cpp:42:
TEST(CoreAnimationAnimatableStrokeDasharrayListTest, EqualTo)
Using the new naming scheme https://codereview.chromium.org/27664002/ introduces
but hasn't landed yet at time of writing.

[dstockwell, 2013-10-20 23:46:26]

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
File Source/core/animation/AnimatableRepeatable.h (right):

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
Source/core/animation/AnimatableRepeatable.h:77: // FIXME: Use a better typing
system for AnimatableValues that doesn't require ugliness like this to support
subclassing.
Why don't we do that now?

(like the toAnimatableRepeatableOverride that we discussed)

[alancutter (OOO until 2018), 2013-10-20 23:53:12]

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
File Source/core/animation/AnimatableRepeatable.h (right):

https://codereview.chromium.org/27572003/diff/1/Source/core/animation/Animata...
Source/core/animation/AnimatableRepeatable.h:77: // FIXME: Use a better typing
system for AnimatableValues that doesn't require ugliness like this to support
subclassing.
On 2013/10/20 23:46:27, dstockwell wrote:
> Why don't we do that now?
> 
> (like the toAnimatableRepeatableOverride that we discussed)

I still consider that in the same league of ugliness and doesn't fix the fixme
but that's just my personal view. I'm fine with either approach though.

[Steve Block, 2013-10-21 02:38:22]

lgtm as a temporary fix, given that we have plans to overhaul the animatable
value system anyway.

[commit-bot: I haz the power, 2013-10-21 05:14:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/27572003/1

[commit-bot: I haz the power, 2013-10-21 05:14:08]

Failed to apply patch for
Source/core/animation/AnimatableStrokeDasharrayListTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
  Copied Source/core/animation/AnimatableNeutralTest.cpp ->
Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
  patching file Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
  Hunk #2 FAILED at 39.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/animation/AnimatableStrokeDasharrayListTest.cpp.rej

Patch:   NR 
Source/core/animation/AnimatableNeutralTest.cpp->Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
Index: Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
diff --git a/Source/core/animation/AnimatableNeutralTest.cpp
b/Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
similarity index 67%
copy from Source/core/animation/AnimatableNeutralTest.cpp
copy to Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
index
07469620675c55dfbf4e852b1f3ec9e611f8fd1a..b688075c1bf8eabbe178f20c61153db5c5b6ff0e
100644
--- a/Source/core/animation/AnimatableNeutralTest.cpp
+++ b/Source/core/animation/AnimatableStrokeDasharrayListTest.cpp
@@ -29,10 +29,9 @@
  */
 
 #include "config.h"
-#include "core/animation/AnimatableNeutral.h"
+#include "core/animation/AnimatableStrokeDasharrayList.h"
 
-#include "core/animation/AnimatableUnknown.h"
-#include "core/css/CSSArrayFunctionValue.h"
+#include "core/svg/SVGLength.h"
 
 #include <gtest/gtest.h>
 
@@ -40,18 +39,22 @@ using namespace WebCore;
 
 namespace {
 
-TEST(AnimatableNeutral, Create)
+TEST(CoreAnimationAnimatableStrokeDasharrayListTest, EqualTo)
 {
-    EXPECT_TRUE(AnimatableValue::neutralValue());
+    Vector<SVGLength> vectorA(4);
+    Vector<SVGLength> vectorB(4);
+    RefPtr<AnimatableStrokeDasharrayList> listA =
AnimatableStrokeDasharrayList::create(vectorA);
+    RefPtr<AnimatableStrokeDasharrayList> listB =
AnimatableStrokeDasharrayList::create(vectorB);
+    EXPECT_TRUE(listA->equals(listB.get()));
+
+    TrackExceptionState es;
+    vectorB[3].newValueSpecifiedUnits(LengthTypePX, 50, es);
+    listB = AnimatableStrokeDasharrayList::create(vectorB);
+    EXPECT_FALSE(listA->equals(listB.get()));
+
+    vectorB = Vector<SVGLength>(5);
+    listB = AnimatableStrokeDasharrayList::create(vectorB);
+    EXPECT_FALSE(listA->equals(listB.get()));
 }
 
-TEST(AnimatableNeutral, Add)
-{
-    RefPtr<CSSValue> cssValue = CSSArrayFunctionValue::create();
-    RefPtr<AnimatableValue> animatableUnknown =
AnimatableUnknown::create(cssValue);
-
-    EXPECT_EQ(cssValue,
toAnimatableUnknown(AnimatableValue::add(animatableUnknown.get(),
AnimatableValue::neutralValue()).get())->toCSSValue());
-    EXPECT_EQ(cssValue,
toAnimatableUnknown(AnimatableValue::add(AnimatableValue::neutralValue(),
animatableUnknown.get()).get())->toCSSValue());
-}
-
-}
+} // namespace

[commit-bot: I haz the power, 2013-10-21 05:46:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/27572003/64001

[commit-bot: I haz the power, 2013-10-21 06:56:45]

Change committed as 160064