Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/animation/AnimatableStrokeDasharrayListTest.cpp

Issue 27572003: Fix assert failure in AnimatableStrokeDasharrayList::equalTo() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/animation/AnimatableNeutral.h" 32 #include "core/animation/AnimatableStrokeDasharrayList.h"
33 33
34 #include "core/animation/AnimatableUnknown.h" 34 #include "core/svg/SVGLength.h"
35 #include "core/css/CSSArrayFunctionValue.h"
36 35
37 #include <gtest/gtest.h> 36 #include <gtest/gtest.h>
38 37
39 using namespace WebCore; 38 using namespace WebCore;
40 39
41 namespace { 40 namespace {
42 41
43 TEST(AnimatableNeutral, Create) 42 TEST(CoreAnimationAnimatableStrokeDasharrayListTest, EqualTo)
alancutter (OOO until 2018) 2013/10/18 00:11:47 Using the new naming scheme https://codereview.chr
44 { 43 {
45 EXPECT_TRUE(AnimatableValue::neutralValue()); 44 Vector<SVGLength> vectorA(4);
45 Vector<SVGLength> vectorB(4);
46 RefPtr<AnimatableStrokeDasharrayList> listA = AnimatableStrokeDasharrayList: :create(vectorA);
47 RefPtr<AnimatableStrokeDasharrayList> listB = AnimatableStrokeDasharrayList: :create(vectorB);
48 EXPECT_TRUE(listA->equals(listB.get()));
49
50 TrackExceptionState es;
51 vectorB[3].newValueSpecifiedUnits(LengthTypePX, 50, es);
52 listB = AnimatableStrokeDasharrayList::create(vectorB);
53 EXPECT_FALSE(listA->equals(listB.get()));
54
55 vectorB = Vector<SVGLength>(5);
56 listB = AnimatableStrokeDasharrayList::create(vectorB);
57 EXPECT_FALSE(listA->equals(listB.get()));
46 } 58 }
47 59
48 TEST(AnimatableNeutral, Add) 60 } // namespace
49 {
50 RefPtr<CSSValue> cssValue = CSSArrayFunctionValue::create();
51 RefPtr<AnimatableValue> animatableUnknown = AnimatableUnknown::create(cssVal ue);
52
53 EXPECT_EQ(cssValue, toAnimatableUnknown(AnimatableValue::add(animatableUnkno wn.get(), AnimatableValue::neutralValue()).get())->toCSSValue());
54 EXPECT_EQ(cssValue, toAnimatableUnknown(AnimatableValue::add(AnimatableValue ::neutralValue(), animatableUnknown.get()).get())->toCSSValue());
55 }
56
57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698