Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/animation/AnimatableRepeatable.h

Issue 27572003: Fix assert failure in AnimatableStrokeDasharrayList::equalTo() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/animation/AnimatableStrokeDasharrayListTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 private: 67 private:
68 virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, do uble fraction) const OVERRIDE; 68 virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, do uble fraction) const OVERRIDE;
69 virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OV ERRIDE; 69 virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OV ERRIDE;
70 70
71 virtual AnimatableType type() const OVERRIDE { return TypeRepeatable; } 71 virtual AnimatableType type() const OVERRIDE { return TypeRepeatable; }
72 virtual bool equalTo(const AnimatableValue*) const OVERRIDE; 72 virtual bool equalTo(const AnimatableValue*) const OVERRIDE;
73 }; 73 };
74 74
75 inline const AnimatableRepeatable* toAnimatableRepeatable(const AnimatableValue* value) 75 inline const AnimatableRepeatable* toAnimatableRepeatable(const AnimatableValue* value)
76 { 76 {
77 ASSERT_WITH_SECURITY_IMPLICATION(value && value->isRepeatable()); 77 // FIXME: Use a better typing system for AnimatableValues that doesn't requi re ugliness like this to support subclassing.
78 ASSERT_WITH_SECURITY_IMPLICATION(value && (value->isRepeatable() || value->i sStrokeDasharrayList()));
78 return static_cast<const AnimatableRepeatable*>(value); 79 return static_cast<const AnimatableRepeatable*>(value);
79 } 80 }
80 81
81 } // namespace WebCore 82 } // namespace WebCore
82 83
83 #endif // AnimatableRepeatable_h 84 #endif // AnimatableRepeatable_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/animation/AnimatableStrokeDasharrayListTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698