Chromium Code Reviews
Help | Chromium Project | Sign in
(60)

Issue 2757173002: Fix counting of ULP and DISABLED_BY_PREF.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 days, 12 hours ago by pdyson
Modified:
11 hours, 29 minutes ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix counting of ULP and DISABLED_BY_PREF. * Move counting of DISABLED_BY_PREF to the correct place. * Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP. BUG=701608

Patch Set 1 #

Total comments: 1

Patch Set 2 : Expand ULP acronym. #

Patch Set 3 : rebase to include lastest code changes #

Patch Set 4 : rebase to include lastest code changes. For real this time. #

Messages

Total messages: 36 (23 generated)
hamelphi
On 2017/03/20 05:57:46, pdyson wrote: > mailto:pdyson@chromium.org changed reviewers: > + mailto:groby@chromium.org, mailto:rogerm@chromium.org FYI, I ...
2 days, 20 hours ago (2017-03-20 19:36:41 UTC) #7
hamelphi
lgtm
2 days, 20 hours ago (2017-03-20 19:37:01 UTC) #9
groby
lgtm
2 days, 20 hours ago (2017-03-20 19:39:13 UTC) #10
Roger McFarlane (Chromium)
lgtm
2 days, 19 hours ago (2017-03-20 20:55:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757173002/1
2 days, 17 hours ago (2017-03-20 22:59:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/389740)
2 days, 17 hours ago (2017-03-20 23:12:42 UTC) #15
pdyson
On 2017/03/22 at 22:42:56, pdyson wrote: > pdyson@chromium.org changed reviewers: > + isherman@chromium.org > - ...
17 hours, 35 minutes ago (2017-03-22 22:44:21 UTC) #19
Ilya Sherman
Are there any changes needed for clients of this proto, to perhaps discard data that's ...
17 hours, 31 minutes ago (2017-03-22 22:48:03 UTC) #20
Ilya Sherman
Sorry, meant to say: LGTM % questions
17 hours, 31 minutes ago (2017-03-22 22:48:33 UTC) #21
hamelphi
On 2017/03/22 22:48:33, Ilya Sherman wrote: > Sorry, meant to say: LGTM % questions TranslateRanker ...
17 hours, 13 minutes ago (2017-03-22 23:06:05 UTC) #22
pdyson
On 2017/03/22 at 22:48:03, isherman wrote: > Are there any changes needed for clients of ...
12 hours, 49 minutes ago (2017-03-23 03:30:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757173002/20001
12 hours, 46 minutes ago (2017-03-23 03:33:29 UTC) #26
commit-bot: I haz the power
12 hours, 30 minutes ago (2017-03-23 03:48:55 UTC) #28
Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62