Fix counting of ULP and DISABLED_BY_PREF.

Fix counting of ULP and DISABLED_BY_PREF.

* Move counting of DISABLED_BY_PREF to the correct place.
* Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP.

BUG=701608
Review-Url: https://codereview.chromium.org/2757173002
Cr-Commit-Position: refs/heads/master@{#459687}
Committed: https://chromium.googlesource.com/chromium/src/+/a12e52d81346dd23d8284763d44c4ee657f11cea

[pdyson, 2017-03-20 04:15:04]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 04:15:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdyson, 2017-03-20 04:18:01]

Description was changed from

==========
Fix counting of ULP and DISABLED_BY_PREF.

Move counting of DISABLED_BY_PREF to the correct place. Count when
translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP.

BUG=701608
==========

to

==========
Fix counting of ULP and DISABLED_BY_PREF.

* Move counting of DISABLED_BY_PREF to the correct place.
* Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP.

BUG=701608
==========

[commit-bot: I haz the power, 2017-03-20 05:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 05:04:07]

Dry run: This issue passed the CQ dry run.

[pdyson, 2017-03-20 05:57:46]

pdyson@chromium.org changed reviewers:
+ groby@chromium.org, rogerm@chromium.org

[hamelphi, 2017-03-20 19:36:41]

On 2017/03/20 05:57:46, pdyson wrote:
> mailto:pdyson@chromium.org changed reviewers:
> + mailto:groby@chromium.org, mailto:rogerm@chromium.org

FYI, I prepared the server-side CL for the proto:
cl/150661130

[hamelphi, 2017-03-20 19:37:01]

hamelphi@chromium.org changed reviewers:
+ hamelphi@chromium.org

[hamelphi, 2017-03-20 19:37:01]

lgtm

[groby-ooo-7-16, 2017-03-20 19:39:13]

lgtm

[Roger McFarlane (Chromium), 2017-03-20 20:55:46]

lgtm

[pdyson, 2017-03-20 22:58:45]

The CQ bit was checked by pdyson@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:59:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 23:12:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdyson, 2017-03-20 23:24:51]

pdyson@chromium.org changed reviewers:
+ isherman@chromium.org

[pdyson, 2017-03-20 23:26:05]

pdyson@chromium.org changed reviewers:
+ asvitkine@chromium.org
- isherman@chromium.org

[pdyson, 2017-03-22 22:42:56]

pdyson@chromium.org changed reviewers:
+ isherman@chromium.org
- asvitkine@chromium.org

[pdyson, 2017-03-22 22:44:21]

On 2017/03/22 at 22:42:56, pdyson wrote:
> pdyson@chromium.org changed reviewers:
> + isherman@chromium.org
> - asvitkine@chromium.org

Ilya, can you take a look at this as an owner of translate_event.proto?

[Ilya Sherman, 2017-03-22 22:48:03]

Are there any changes needed for clients of this proto, to perhaps discard data
that's incorrectly labeled?

https://codereview.chromium.org/2757173002/diff/1/components/metrics/proto/tr...
File components/metrics/proto/translate_event.proto (right):

https://codereview.chromium.org/2757173002/diff/1/components/metrics/proto/tr...
components/metrics/proto/translate_event.proto:134: // The translate UI was not
shown because the language is in the user's ULP.
nit: What's a ULP?  I'm not familiar with the acronym.  Is it worth expanding
here for others who might also be unfamiliar?

[Ilya Sherman, 2017-03-22 22:48:33]

Sorry, meant to say: LGTM % questions

[hamelphi, 2017-03-22 23:06:05]

On 2017/03/22 22:48:33, Ilya Sherman wrote:
> Sorry, meant to say: LGTM % questions

TranslateRanker is the main client of this proto. Events of this type are not
used for now, so it should not have any impact. We are aware of the bug, and can
filter logs by Chrome version once we start monitoring these. I am not aware of
other clients that currently depend on these types of events.

[pdyson, 2017-03-23 03:30:37]

On 2017/03/22 at 22:48:03, isherman wrote:
> Are there any changes needed for clients of this proto, to perhaps discard
data that's incorrectly labeled?
> 
>
https://codereview.chromium.org/2757173002/diff/1/components/metrics/proto/tr...
> File components/metrics/proto/translate_event.proto (right):
> 
>
https://codereview.chromium.org/2757173002/diff/1/components/metrics/proto/tr...
> components/metrics/proto/translate_event.proto:134: // The translate UI was
not shown because the language is in the user's ULP.
> nit: What's a ULP?  I'm not familiar with the acronym.  Is it worth expanding
here for others who might also be unfamiliar?

I've expanded the acronym now.

[pdyson, 2017-03-23 03:33:17]

The CQ bit was checked by pdyson@chromium.org

[pdyson, 2017-03-23 03:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
hamelphi@chromium.org, isherman@chromium.org, rogerm@chromium.org
Link to the patchset: https://codereview.chromium.org/2757173002/#ps20001
(title: "Expand ULP acronym.")

[commit-bot: I haz the power, 2017-03-23 03:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 03:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:48:55]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pdyson, 2017-03-23 04:03:13]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 04:03:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 04:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 04:18:35]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pdyson, 2017-03-23 04:32:11]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 04:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 04:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 04:50:48]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pdyson, 2017-03-26 23:38:08]

The CQ bit was checked by pdyson@chromium.org

[pdyson, 2017-03-26 23:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
hamelphi@chromium.org, isherman@chromium.org, rogerm@chromium.org
Link to the patchset: https://codereview.chromium.org/2757173002/#ps60001
(title: "rebase to include lastest code changes. For real this time.")

[commit-bot: I haz the power, 2017-03-26 23:38:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 01:27:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490571488538760,
"parent_rev": "3c1d1f31c293867ecd7f90d60419e5a13d503408", "commit_rev":
"a12e52d81346dd23d8284763d44c4ee657f11cea"}

[commit-bot: I haz the power, 2017-03-27 01:29:11]

Description was changed from

==========
Fix counting of ULP and DISABLED_BY_PREF.

* Move counting of DISABLED_BY_PREF to the correct place.
* Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP.

BUG=701608
==========

to

==========
Fix counting of ULP and DISABLED_BY_PREF.

* Move counting of DISABLED_BY_PREF to the correct place.
* Count when translate is not used due to ULP using a new enum: LANGUAGE_IN_ULP.

BUG=701608

Review-Url: https://codereview.chromium.org/2757173002
Cr-Commit-Position: refs/heads/master@{#459687}
Committed:
https://chromium.googlesource.com/chromium/src/+/a12e52d81346dd23d8284763d44c...
==========

[commit-bot: I haz the power, 2017-03-27 01:29:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a12e52d81346dd23d8284763d44c...